Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

open-tv: Add version 1.3.0 #14245

Merged
merged 9 commits into from
Jan 14, 2025
Merged

open-tv: Add version 1.3.0 #14245

merged 9 commits into from
Jan 14, 2025

Conversation

Fredolx
Copy link
Contributor

@Fredolx Fredolx commented Oct 18, 2024

Added Open TV to Extras

@github-actions GitHub Actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

open-tv

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@aliesbelik aliesbelik added the package-request-needed Need package-request issue label Oct 18, 2024
@rasa
Copy link
Member

rasa commented Dec 29, 2024

/verify

@rasa rasa changed the title Add Open TV open-tv: Add version 1.0.3: Ultra-fast, simple and open-source IPTV app Dec 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

Your changes do not pass checks.

open-tv

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@rasa
Copy link
Member

rasa commented Dec 30, 2024

@Fredolx Checkver is failing. Please advise. Thx.

@Fredolx
Copy link
Contributor Author

Fredolx commented Jan 13, 2025

Should be fixed now

@bt4ibwem8
Copy link
Contributor

/verify

@github-actions GitHub Actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

open-tv

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@bt4ibwem8
Copy link
Contributor

bt4ibwem8 commented Jan 13, 2025 •
edited
Loading

Closes #14726

@bt4ibwem8
Copy link
Contributor

/verify

@github-actions GitHub Actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

open-tv

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@bt4ibwem8
Copy link
Contributor

bt4ibwem8 commented Jan 13, 2025 •
edited
Loading

@Fredolx
I linked the package request, but does not work. Probably it is needed to do it by you, as the creator of this PR

@aliesbelik aliesbelik linked an issue Jan 13, 2025 that may be closed by this pull request
[Request]: open-tv #14726
Closed
6 tasks
@aliesbelik aliesbelik removed the package-request-needed Need package-request issue label Jan 13, 2025
@aliesbelik aliesbelik changed the title open-tv: Add version 1.0.3: Ultra-fast, simple and open-source IPTV app open-tv: Add version 1.3.0 Jan 13, 2025
aliesbelik
aliesbelik requested changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@aliesbelik aliesbelik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Fix EOF.
  • Follow the standard order of fields in the json file, as per Contributing Guide.

bucket/open-tv.json Outdated Show resolved Hide resolved
Fredolx and others added 2 commits January 13, 2025 21:27
@Fredolx
Copy link
Contributor Author

Fredolx commented Jan 14, 2025

I fixed the order of fields and applied the code suggestion. I am not sure about the package request, do you want me to create one or add a comment to the one you linked?

@rasa rasa merged commit 48d1b6e into ScoopInstaller:master Jan 14, 2025
@aliesbelik
Copy link
Collaborator

I am not sure about the package request, do you want me to create one or add a comment to the one you linked?

Not actual more.
Someone has created one (#14726).

As per the Contributing Guide the normal flow is to create first request for new app/package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliesbelik aliesbelik aliesbelik requested changes

Assignees
No one assigned
Labels
review-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Request]: open-tv
4 participants
@Fredolx @rasa @bt4ibwem8 @aliesbelik