Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wcurl: Update manifest #6117

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

wcurl: Update manifest #6117

wants to merge 1 commit into from

Conversation

sitiom
Copy link
Contributor

@sitiom sitiom commented Aug 19, 2024

  • Fix homepage order

  • Point url to the wcurl script instead of the entire archive.

  • Move depends to suggest & remove busybox dependency (Scoop automatically creates a shim to bash)

  • I have read the Contributing Guide.

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

wcurl

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Copy link
Contributor Author

@sitiom sitiom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue: wcurl doesn't show output due to a bug with Scoop (ScoopInstaller/Scoop#6112)

@niheaven
Copy link
Member

Issue: wcurl doesn't show output due to a bug with Scoop (ScoopInstaller/Scoop#6112)

That's why the origin manifest use an explicit sh in shim creation. And why install such a big git app just for a sh shell?

BTW, curl and sh is depends, not suggests for this script.

@sitiom
Copy link
Contributor Author

sitiom commented Aug 19, 2024

I'm trying to copy the neofetch manifest here. git is just a suggestion, the machine may already have bash installed (WSL) which I assume the shim already tries to find first.

BTW, curl and sh is depends, not suggests for this script.

curl is already built-in to Windows 10. Most "dependencies" in these buckets use suggest instead of depends to account for dependencies installed outside Scoop, don't they?

@niheaven
Copy link
Member

WSL's bash is very slow as I tried... So when I modify the manifest, I just keep sh and add busybox as depends.

curl is bundled since Windows 10 version 17063, but as scoop's min system requirement is Windows 7, leave it depends now.

@niheaven
Copy link
Member

Most "dependencies" in these buckets use suggest instead of depends to account for dependencies installed outside Scoop, don't they?

The additional feature depends is moved to suggests, but functional depends (curl for wcurl) is still depends, e.g., r for rstudio.

@sitiom
Copy link
Contributor Author

sitiom commented Aug 19, 2024

The additional feature depends is moved to suggests, but functional depends (curl for wcurl) is still depends, e.g., r for rstudio.

vcredist as a functional dependency is listed as suggest though 🤔

@sitiom
Copy link
Contributor Author

sitiom commented Aug 19, 2024

Issue: wcurl doesn't show output due to a bug with Scoop (ScoopInstaller/Scoop#6112)

@niheaven
Copy link
Member

vcredist as a functional dependency is listed as suggest though 🤔

It is common for many machines to have vcredist already installed, so vcredist is marked as suggests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants