Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shortcuts): find target in dir and Path #6244

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

kengwang
Copy link

@kengwang kengwang commented Dec 16, 2024

Description

The shortcut target should find where the target is just like where the shim creation does. Not just append to $dir

Motivation and Context

Closes #6243

How Has This Been Tested?

It now can successfully create the shortcut below

"shortcuts": [
        [
            "java",
            "App",
            "-jar \"$dir/App.jar\""
        ]
    ]

and it won't break the backward compatibility

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant