Fix deprecation of request service, upgrade minimum symfony version t…

…o 2.4 (#4)
ScullWM · May 2, 2017 · e8a8549 · e8a8549
1 parent 86d3018
commit e8a8549
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 16 deletions.
diff --git a/Resources/config/apiService.yml b/Resources/config/apiService.yml
@@ -8,31 +8,31 @@ parameters:
 
 services:
     swm.mail_hook.api_service.campainmonitor:
-        class: %swm.mail_hook.api_service.campainmonitor.class%
+        class: "%swm.mail_hook.api_service.campainmonitor.class%"
         tags:
             -  { name: swm.mailhook, alias: campainmonitor }
 
     swm.mail_hook.api_service.mailgun:
-        class: %swm.mail_hook.api_service.mailgun.class%
+        class: "%swm.mail_hook.api_service.mailgun.class%"
         tags:
             -  { name: swm.mailhook, alias: mailgun }
 
     swm.mail_hook.api_service.mailjet:
-        class: %swm.mail_hook.api_service.mailjet.class%
+        class: "%swm.mail_hook.api_service.mailjet.class%"
         tags:
             -  { name: swm.mailhook, alias: mailjet }
 
     swm.mail_hook.api_service.mandrill:
-        class: %swm.mail_hook.api_service.mandrill.class%
+        class: "%swm.mail_hook.api_service.mandrill.class%"
         tags:
             -  { name: swm.mailhook, alias: mandrill }
 
     swm.mail_hook.api_service.sendgrid:
-        class: %swm.mail_hook.api_service.sendgrid.class%
+        class: "%swm.mail_hook.api_service.sendgrid.class%"
         tags:
             -  { name: swm.mailhook, alias: sendgrid }
 
     swm.mail_hook.api_service.sparkpost:
-        class: %swm.mail_hook.api_service.sparkpost.class%
+        class: "%swm.mail_hook.api_service.sparkpost.class%"
         tags:
             -  { name: swm.mailhook, alias: sparkpost }
diff --git a/Resources/config/service.yml b/Resources/config/service.yml
@@ -6,15 +6,15 @@ parameters:
 
 services:
     swm.mail_hook.service.mail_hook:
-        class: %swm.mail_hook.service.mail_hook.class%
+        class: "%swm.mail_hook.service.mail_hook.class%"
         scope: request
         arguments:
-            - @request
-            - @swm.mail_hook.provider.api_service
+            - "@request_stack"
+            - "@swm.mail_hook.provider.api_service"
 
     swm.mail_hook.provider.api_service:
-        class: %swm.mail_hook.provider.api_service.class%
+        class: "%swm.mail_hook.provider.api_service.class%"
 
     swm.mail_hook.hydrator.default:
-        class: %swm.mail_hook.hydrator.default.class%
+        class: "%swm.mail_hook.hydrator.default.class%"
 
diff --git a/Service/MailHookService.php b/Service/MailHookService.php
@@ -6,6 +6,7 @@
 use Swm\Bundle\MailHookBundle\Model as ApiServiceModel;
 use Swm\Bundle\MailHookBundle\Provider\ProviderInterface;
 use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\HttpFoundation\RequestStack;
 
 class MailHookService
 {
@@ -20,17 +21,17 @@ class MailHookService
     private $apiServiceModelProvider;
 
     /**
-     * @param  Request           $request
+     * @param  RequestStack      $requestStack
      * @param  ProviderInterface $apiServiceProvider
      */
-    public function __construct(Request $request, ProviderInterface $apiServiceProvider)
+    public function __construct(RequestStack $requestStack, ProviderInterface $apiServiceProvider)
     {
-        $this->request            = $request;
+        $this->request            = $requestStack->getCurrentRequest();
         $this->apiServiceProvider = $apiServiceProvider;
     }
 
     /**
-     * @param  string $apiService
+     * @param  string $serviceName
      * @return array<HookInterface>
      */
     public function getHooksForService($serviceName)

diff --git a/composer.json b/composer.json
@@ -13,7 +13,7 @@
     ],
     "require": {
         "php": ">=5.3.9",
-        "symfony/framework-bundle": "~2.3|~3.0"
+        "symfony/framework-bundle": "~2.4|~3.0"
     },
     "require-dev": {
         "atoum/atoum": "dev-master"