Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports time crate #602

Merged
merged 3 commits into from
Mar 20, 2022
Merged

Supports time crate #602

merged 3 commits into from
Mar 20, 2022

Conversation

billy1624
Copy link
Member

@billy1624 billy1624 self-assigned this Mar 13, 2022
@billy1624 billy1624 marked this pull request as ready for review March 13, 2022 10:35
@billy1624 billy1624 requested a review from tyt2y3 March 13, 2022 10:35
@@ -36,6 +36,39 @@ pub type DateTimeUtc = chrono::DateTime<chrono::Utc>;
#[cfg(feature = "with-chrono")]
pub type DateTimeLocal = chrono::DateTime<chrono::Local>;

#[cfg(feature = "with-chrono")]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there an abstract way which would do this faster rather than importing the #[cfg()] macro always.

Comment on lines +27 to +33
date: date!(2022 - 03 - 13),
time: time!(16:24:00),
date_time: date!(2022 - 03 - 13).with_time(time!(16:24:00)),
date_time_tz: date!(2022 - 03 - 13)
.with_time(time!(16:24:00))
.assume_utc(),
};

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, changes. Good work👍

@tyt2y3 tyt2y3 merged commit fe1f763 into master Mar 20, 2022
@tyt2y3 tyt2y3 deleted the support-time-crate branch March 20, 2022 16:02
@tasn
Copy link
Contributor

tasn commented Mar 20, 2022

Yay, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Support the time crate in addition (instead of?) chrono
4 participants