-
-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supports time
crate
#602
Merged
Merged
Supports time
crate
#602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -36,6 +36,39 @@ pub type DateTimeUtc = chrono::DateTime<chrono::Utc>; | |||
#[cfg(feature = "with-chrono")] | |||
pub type DateTimeLocal = chrono::DateTime<chrono::Local>; | |||
|
|||
#[cfg(feature = "with-chrono")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there an abstract way which would do this faster rather than importing the #[cfg()]
macro always.
Comment on lines
+27
to
+33
date: date!(2022 - 03 - 13), | ||
time: time!(16:24:00), | ||
date_time: date!(2022 - 03 - 13).with_time(time!(16:24:00)), | ||
date_time_tz: date!(2022 - 03 - 13) | ||
.with_time(time!(16:24:00)) | ||
.assume_utc(), | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, changes. Good work👍
Yay, thanks a lot! |
billy1624
added a commit
to SeaQL/seaql.github.io
that referenced
this pull request
Mar 25, 2022
This was referenced Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Info
time
along with withchrono
sea-query#267Adds
time
crate