Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

CORTX-30785: Fixing the Alex bug #242

Merged
merged 2 commits into from
May 13, 2022
Merged

Conversation

mukul-seagate11
Copy link
Contributor

Signed-off-by: Mukul Malhotra [email protected]

Description

Alex's Github Action is fails with an error "reviewdog: PullRequest needs 'git' command: failed to run 'git rev-parse --show-prefix'"

Type of change

Changed the permissions of the directory where the target repository is checkout in the workflow of GitHub Actions.

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds new functionality)
  • Breaking change (bug fix or new feature that breaks existing functionality)
  • Third-party dependency update
  • Documentation additions or improvements
  • Code quality improvements to existing code or test additions/updates

Applicable issues

  • This change fixes an issue: #
  • This change is related to an issue: #

CORTX image version requirements

This change requires the following images:

  • cortx-all:<version>
  • cortx-rgw:<version>

How was this tested?

Additional information

Checklist

  • The change is tested and works locally.
  • New or changed settings in the solution YAML are documented clearly in the README.md file.
  • All commits are signed off and are in agreement with the CORTX Community DCO and CLA policy.

If this change addresses a CORTX Jira issue:

  • The title of the PR starts with the issue ID (e.g. CORTX-XXXXX:)

Signed-off-by: Mukul Malhotra <[email protected]>
@mukul-seagate11 mukul-seagate11 requested a review from a team as a code owner May 13, 2022 08:58
@cla-bot cla-bot bot added the cla-signed label May 13, 2022
@mukul-seagate11
Copy link
Contributor Author

@keithpine @walterlopatka, #243 raised for main branch too

@keithpine keithpine changed the title CORTX-30785: Fixing the Alex bug for integration branch CORTX-30785: Fixing the Alex bug May 13, 2022
Copy link
Contributor

@walterlopatka walterlopatka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm (though I am not an expert in github workflows)

Signed-off-by: Keith Pine <[email protected]>
@keithpine keithpine merged commit 568dc8a into integration May 13, 2022
@keithpine keithpine deleted the alex-bugfix-integration branch May 13, 2022 14:45
@keithpine
Copy link
Contributor

Thanks @mukul-seagate11 . This will make it to the main branch next time there's a release and a merge is done.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants