This repository has been archived by the owner on Feb 8, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 47
CORTX-31350: Expose Cpu & Memory limits for all CORTX Services #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rick Osowski <[email protected]>
Signed-off-by: Rick Osowski <[email protected]>
Signed-off-by: Rick Osowski <[email protected]>
Signed-off-by: Rick Osowski <[email protected]>
Signed-off-by: Rick Osowski <[email protected]>
Signed-off-by: Rick Osowski <[email protected]>
Signed-off-by: Rick Osowski <[email protected]>
10 tasks
Signed-off-by: Rick Osowski <[email protected]>
keithpine
approved these changes
May 16, 2022
Signed-off-by: Rick Osowski <[email protected]>
walterlopatka
approved these changes
May 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
keithpine
suggested changes
May 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
solution-check.yaml
is missing the newly added required resource values.
keithpine
reviewed
May 17, 2022
…pose_cpu_memory_limits
Signed-off-by: Rick Osowski <[email protected]>
keithpine
approved these changes
May 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't test personally, but LGTM.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for CORTX Pod's requests and limits for CPU & Memory when deploying to Kubernetes. This configuration capability is exposed through the solution.yaml interface and interned by the deploy scripts and Helm Charts to apply the specific values to the deployed Pods and generated ConfigMaps. Users can now control the amount of CPU & Memory deployed CORTX artifacts will have available directly from solution.yaml.
Type of change
Applicable issues
How was this tested?
Tested locally with using default requests & limits, as well as customizing requests & limits per Kubernetes standards.
Checklist
If this change addresses a CORTX Jira issue:
CORTX-XXXXX:
)View rendered README.md