Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

CORTX-31350: Expose Cpu & Memory limits for all CORTX Services #248

Merged
merged 11 commits into from
May 17, 2022

Conversation

osowski
Copy link
Contributor

@osowski osowski commented May 16, 2022

Description

This PR adds support for CORTX Pod's requests and limits for CPU & Memory when deploying to Kubernetes. This configuration capability is exposed through the solution.yaml interface and interned by the deploy scripts and Helm Charts to apply the specific values to the deployed Pods and generated ConfigMaps. Users can now control the amount of CPU & Memory deployed CORTX artifacts will have available directly from solution.yaml.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds new functionality)
  • Breaking change (bug fix or new feature that breaks existing functionality)
  • Third-party dependency update
  • Documentation additions or improvements
  • Code quality improvements to existing code or test additions/updates

Applicable issues

  • This change fixes an issue: CORTX-31350
  • This change is related to an issue: Feature F-40B (CORTX-27851)

How was this tested?

Tested locally with using default requests & limits, as well as customizing requests & limits per Kubernetes standards.

Checklist

  • The change is tested and works locally.
  • New or changed settings in the solution YAML are documented clearly in the README.md file.
  • All commits are signed off and are in agreement with the CORTX Community DCO and CLA policy.

If this change addresses a CORTX Jira issue:

  • The title of the PR starts with the issue ID (e.g. CORTX-XXXXX:)

View rendered README.md

@osowski osowski self-assigned this May 16, 2022
@cla-bot cla-bot bot added the cla-signed label May 16, 2022
@osowski osowski marked this pull request as ready for review May 16, 2022 21:29
@osowski osowski requested a review from a team as a code owner May 16, 2022 21:29
charts/cortx/templates/_config.yaml.tpl Outdated Show resolved Hide resolved
Copy link
Contributor

@walterlopatka walterlopatka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@keithpine keithpine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solution-check.yaml is missing the newly added required resource values.

Copy link
Contributor

@keithpine keithpine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test personally, but LGTM.

@osowski osowski merged commit 65e37a7 into integration May 17, 2022
@walterlopatka walterlopatka added this to the v0.6.0 milestone May 19, 2022
@osowski osowski deleted the CORTX-31350_expose_cpu_memory_limits branch June 2, 2022 15:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants