Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

fix missing namespace during chart install #254

Merged
merged 1 commit into from
May 19, 2022
Merged

fix missing namespace during chart install #254

merged 1 commit into from
May 19, 2022

Conversation

keithpine
Copy link
Contributor

@keithpine keithpine commented May 18, 2022

Description

Fixes a regression where installing the Helm charts into a non-default namespace fails.

The cortx-platform chart was previously creating the namespace automatically. That chart was removed for CORTX-30141, but no change was added to create the namespace elsewhere.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds new functionality)
  • Breaking change (bug fix or new feature that breaks existing functionality)
  • Third-party dependency update
  • Documentation additions or improvements
  • Code quality improvements to existing code or test additions/updates

Applicable issues

How was this tested?

Deployed without the namespace previously existing.

Checklist

  • The change is tested and works locally.
  • New or changed settings in the solution YAML are documented clearly in the README.md file.
  • All commits are signed off and are in agreement with the CORTX Community DCO and CLA policy.

If this change addresses a CORTX Jira issue:

  • The title of the PR starts with the issue ID (e.g. CORTX-XXXXX:)

@keithpine keithpine requested a review from a team as a code owner May 18, 2022 22:57
@cla-bot cla-bot bot added the cla-signed label May 18, 2022
Copy link
Contributor

@osowski osowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@osowski osowski merged commit d2a730e into Seagate:integration May 19, 2022
@keithpine keithpine deleted the create-namespace branch July 25, 2022 22:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants