Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

Bash script for creating py-utils test rpm. #692

Merged
merged 4 commits into from
Jan 13, 2022
Merged

Bash script for creating py-utils test rpm. #692

merged 4 commits into from
Jan 13, 2022

Conversation

veerendra-simha-garikipati
Copy link
Contributor

@veerendra-simha-garikipati veerendra-simha-garikipati commented Jan 10, 2022 •
edited
Loading

Signed-off-by: Veerendra Garikipati [email protected]

Problem Statement

  • Bash script for creating py-utils test rpm.

Design

Coding

  • Coding conventions are followed and code is consistent [Y/N]: Y
  • Confirm All CODACY errors are resolved [Y/N]: Y

Testing

  • Confirm that Test Cases are added (for both the cases, fix and feature) [Y/N]: N
  • Confirm Test Cases cover Happy Path, Non-Happy Path and Scalability [Y/N]: N
  • Confirm Testing was performed with installed RPM [Y/N]: Y

Review Checklist

Before posting the PR please ensure

  • PR is self reviewed
  • Is there a change in filename/package/module or signature [Y/N]:
  • If yes for above point, Is a notification sent to all other cortx components [Y/N]
  • Jira is updated
  • Check if the description is clear and explained.
  • Check Acceptance Criterion is defined.
  • All the tests performed should be mentioned before Resolving a JIRA.
  • Verification needs to be done before marked as Closed/Verified

Documentation

  • Changes done to WIKI / Confluence page

View rendered py-utils/test/README.md

@veerendra-simha-garikipati
Bash script for creating test rpm.
7c6ec61 
Signed-off-by: Veerendra Garikipati <[email protected]>
sachinpunadikar
sachinpunadikar approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@sachinpunadikar sachinpunadikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, rest all looks good

@veerendra-simha-garikipati
updating copyright year to 2022
a5876aa 
Signed-off-by: Veerendra Garikipati <[email protected]>
rahul-tripathi-git
rahul-tripathi-git approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@rahul-tripathi-git rahul-tripathi-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@sachinpunadikar sachinpunadikar merged commit 61edb2c into Seagate:main Jan 13, 2022
@veerendra-simha-garikipati veerendra-simha-garikipati deleted the EOS-27312 branch January 21, 2022 15:51
suryakumar1024 pushed a commit to suryakumar1024/cortx-utils that referenced this pull request Mar 21, 2022
@veerendra-simha-garikipati @suryakumar1024
Bash script for creating py-utils test rpm. (Seagate#692)
a15afba 
* Bash script for creating test rpm.

Signed-off-by: Veerendra Garikipati <[email protected]>

* updating copyright year to 2022

Signed-off-by: Veerendra Garikipati <[email protected]>

Co-authored-by: Sachin Punadikar <[email protected]>
Signed-off-by: suryakumar.kumaravelan <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rahul-tripathi-git rahul-tripathi-git rahul-tripathi-git approved these changes

@vastradparayya vastradparayya vastradparayya approved these changes

@sachinpunadikar sachinpunadikar sachinpunadikar approved these changes

@ujjwalpl ujjwalpl ujjwalpl approved these changes

@ajaysrivas ajaysrivas Awaiting requested review from ajaysrivas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@veerendra-simha-garikipati @ujjwalpl @sachinpunadikar @vastradparayya @rahul-tripathi-git