Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

EOS-27348: replace use of CortxConf class to MappedConf #716

Merged
merged 4 commits into from
Jan 21, 2022
Merged

EOS-27348: replace use of CortxConf class to MappedConf #716

merged 4 commits into from
Jan 21, 2022

Conversation

rohit-k-dwivedi
Copy link
Contributor

@rohit-k-dwivedi rohit-k-dwivedi commented Jan 19, 2022 •
edited
Loading

Signed-off-by: Rohit Dwivedi [email protected]

Problem Statement

  • Replace use of CortxConf class with MappedConf

Design

  • For Bug describe the fix here.
  • For Feature, Post the link to the solution page on the confluence CORTX Foundation Library

Coding

  • Coding conventions are followed and code is consistent [Y/N]: Y
  • Confirm All CODACY errors are resolved [Y/N]: Y

Testing

  • Confirm that Test Cases are added (for both the cases, fix and feature) [Y/N]:
  • Confirm Test Cases cover Happy Path, Non-Happy Path and Scalability [Y/N]:
  • Confirm Testing was performed with installed RPM [Y/N]:

Review Checklist

Before posting the PR please ensure

  • PR is self reviewed
  • Is there a change in filename/package/module or signature [Y/N]:
  • If yes for above point, Is a notification sent to all other cortx components [Y/N]
  • Jira is updated
  • Check if the description is clear and explained.
  • Check Acceptance Criterion is defined.
  • All the tests performed should be mentioned before Resolving a JIRA.
  • Verification needs to be done before marked as Closed/Verified

Documentation

  • Changes done to WIKI / Confluence page

sachinpunadikar
sachinpunadikar suggested changes Jan 20, 2022
View reviewed changes
Copy link
Contributor

@sachinpunadikar sachinpunadikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

work on review comments

@rohit-k-dwivedi rohit-k-dwivedi force-pushed the EOS-27348_PATCH_2 branch 5 times, most recently from cace38d to 899e643 Compare January 20, 2022 14:40
@rohit-k-dwivedi
EOS-27348: Remove CortxConf
cc8b065 
Signed-off-by: Rohit Dwivedi <[email protected]>
@rohit-k-dwivedi rohit-k-dwivedi changed the title WIP: EOS-27348: Remove CortxConf class WIP: EOS-27348: replace use of CortxConf class to MappedConf Jan 21, 2022
@rohit-k-dwivedi rohit-k-dwivedi changed the title WIP: EOS-27348: replace use of CortxConf class to MappedConf EOS-27348: replace use of CortxConf class to MappedConf Jan 21, 2022
sachinpunadikar
sachinpunadikar approved these changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@sachinpunadikar sachinpunadikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sachinpunadikar sachinpunadikar merged commit 3d221fb into Seagate:main Jan 21, 2022
suryakumar1024 pushed a commit to suryakumar1024/cortx-utils that referenced this pull request Mar 21, 2022
@rohit-k-dwivedi @suryakumar1024
EOS-27348: replace use of CortxConf class to MappedConf (Seagate#716)
c37b3ea 
* EOS-27348: Remove CortxConf

Signed-off-by: Rohit Dwivedi <[email protected]>

* renamed variable from cluster_conf_mapped to cluster_conf

Signed-off-by: Rohit Dwivedi <[email protected]>

Co-authored-by: Sachin Punadikar <[email protected]>
Signed-off-by: suryakumar.kumaravelan <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sachinpunadikar sachinpunadikar sachinpunadikar approved these changes

@ujjwalpl ujjwalpl ujjwalpl approved these changes

@ajaysrivas ajaysrivas Awaiting requested review from ajaysrivas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rohit-k-dwivedi @ujjwalpl @sachinpunadikar