Hs 312/sas device not found #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade to klogv2 for compatibility with libraries using klogv2 such as csi-lib-sas and for future-proofing
Occasionally previously removed devices which have not yet been removed from the array can be rediscovered by a rapid subsequent NodePublishVolume. To alleviate this for now, maintain a list of previously deleted devices and remove them.
seagate-chris
requested changes
Dec 9, 2022
jskazinski
approved these changes
Dec 12, 2022
go.mod
Outdated
| @@ -37,7 +37,7 @@ require ( | |||
| google.golang.org/protobuf v1.28.1 // indirect | |||
| gopkg.in/tomb.v1 v1.0.0-20141024135613-dd632973f1e7 // indirect | |||
| gopkg.in/yaml.v2 v2.4.0 // indirect | |||
| k8s.io/klog/v2 v2.70.0 // indirect | |||
| k8s.io/klog v1.0.0 // indirect | |||
There was a problem hiding this comment.
This leads me to think that we are still using klog v1 somewhere, or is that related to klog v2 having a relationship with klog v1?
seagate-chris
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To mitigate possibility of a device that is in the process of being removed from being re-discovered by a subsequent NodePublishVolume call, maintain a list of previously removed devices and search for / re-remove them during publishing