Remove obsoleted with error API. Fixes #99

SeanFeldman · Nov 12, 2019 · 76567bd · 76567bd
1 parent db5b2cf
commit 76567bd
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 16 deletions.
diff --git a/...tachmentPlugin.Tests/ApprovalFiles/ApiApprovals.AzureStorageAttachmentPlugin.approved.txt b/...tachmentPlugin.Tests/ApprovalFiles/ApiApprovals.AzureStorageAttachmentPlugin.approved.txt
@@ -10,8 +10,6 @@ namespace Microsoft.Azure.ServiceBus
     public class static AzureStorageAttachmentConfigurationExtensions
     {
         public static Microsoft.Azure.ServiceBus.AzureStorageAttachmentConfiguration WithBlobSasUri(this Microsoft.Azure.ServiceBus.AzureStorageAttachmentConfiguration azureStorageAttachmentConfiguration, string messagePropertyToIdentifySasUri = "$attachment.sas.uri", System.Nullable<System.TimeSpan> sasTokenValidationTime = null) { }
-        [System.ObsoleteAttribute("Will be removed in version 6. Use replacement API \'.WithBlobSasUri()\' instead.", true)]
-        public static Microsoft.Azure.ServiceBus.AzureStorageAttachmentConfiguration WithSasUri(this Microsoft.Azure.ServiceBus.AzureStorageAttachmentConfiguration azureStorageAttachmentConfiguration, string messagePropertyToIdentifySasUri = "$attachment.sas.uri", System.Nullable<System.TimeSpan> sasTokenValidationTime = null) { }
     }
     public class static AzureStorageAttachmentExtensions
     {

diff --git a/src/ServiceBus.AttachmentPlugin/AzureStorageAttachmentConfigurationExtensions.cs b/src/ServiceBus.AttachmentPlugin/AzureStorageAttachmentConfigurationExtensions.cs
@@ -10,20 +10,6 @@ public static class AzureStorageAttachmentConfigurationExtensions
         internal const string DefaultMessagePropertyToIdentitySasUri = "$attachment.sas.uri";
         internal static TimeSpan DefaultSasTokenValidationTime = TimeSpan.FromDays(7);
 
-        /// <summary>
-        /// Adds blob SAS URI configuration.
-        /// </summary>
-        /// <param name="azureStorageAttachmentConfiguration"></param>
-        /// <param name="messagePropertyToIdentifySasUri">The <see cref="Message"/> user property used for SAS uri.</param>
-        /// <param name="sasTokenValidationTime">The time SAS uri is valid for.</param>
-        /// <returns></returns>
-        [Obsolete("Will be removed in version 6. Use replacement API '." + nameof(WithBlobSasUri) + "()' instead.", true)]
-        public static AzureStorageAttachmentConfiguration WithSasUri(
-            this AzureStorageAttachmentConfiguration azureStorageAttachmentConfiguration,
-            string messagePropertyToIdentifySasUri = DefaultMessagePropertyToIdentitySasUri,
-            TimeSpan? sasTokenValidationTime = null)
-            => throw new Exception("Deprecated with error. See documentation for all configuration options.");
-
         /// <summary>
         /// Adds blob SAS URI configuration.
         /// </summary>