Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Microsoft.Azure.Storage.Blob instead of WindowsAzure.Storage #116

Closed
SeanFeldman opened this issue Jun 21, 2019 · 12 comments
Closed

Use Microsoft.Azure.Storage.Blob instead of WindowsAzure.Storage #116

SeanFeldman opened this issue Jun 21, 2019 · 12 comments
Milestone

Comments

@SeanFeldman
Copy link
Owner

Microsoft.Azure.Storage.Blob is the continuation of WindowsAzure.Storage, specifically designed for Azure Storage Blobs.

@SeanFeldman SeanFeldman added this to the 6.0.0 milestone Jun 21, 2019
@CasperWSchmidt
Copy link

Any ETA for 6.0.0? I would like to void dependencies on WindowsAzure.Storage in my project, but am considering this package for implementing the claim check pattern you described here :)

@SeanFeldman
Copy link
Owner Author

@CasperWSchmidt sorry, got a bit distracted. I'm hoping to get to this by the weekend and let a preview version out to see if there's anything major. If nothing is found, shortly after to have an RTM.

@SeanFeldman
Copy link
Owner Author

6.0.0-preview01 is on NuGet. Give it a whirl and if no issues identified in a few days, I'll release the stable.

@SeanFeldman
Copy link
Owner Author

@CasperWSchmidt give it a try?

@CasperWSchmidt
Copy link

I will, but it looks good 😊

@SeanFeldman
Copy link
Owner Author

The tests are green, but I don't know how people use it and wherever there's an edge case or not.

@CasperWSchmidt
Copy link

I have just started using it in an internal NuGet package for our infrastructure (communication with Azure Service Bus, Application Insights etc.)
I had to wrap it though to enable unit testing but I guess that's a different issue :)

@SeanFeldman
Copy link
Owner Author

I had to wrap it though to enable unit testing but I guess that's a different issue :)

Please raise the issue if that's affecting you.

Looking forward to your confirmation it's working well with the new dependencies.

@CasperWSchmidt
Copy link

Everything looks fine. I have worked around the missing interface by abstracting the library away behind my own implementation😊
I do have issues with the key vault extension however, and have created issues in that repository

@SeanFeldman
Copy link
Owner Author

I do have issues with the key vault extension however, and have created issues in that repository

Sounds good. I'll have a look at those.
Thank you for verifying. I'll have a look at the keyvault issues. If they are unrelated to this repo, will push out an RTM this week.

@SeanFeldman
Copy link
Owner Author

I'm adding nullable reference types in v6 (C# 8) via PR #151

SeanFeldman added a commit that referenced this issue Nov 12, 2019

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
SeanFeldman added a commit that referenced this issue Nov 12, 2019
* Bump MarkdownSnippets from 10.3.0 to 12.0.3 in /src (#124)

Bumps [MarkdownSnippets](https://github.com/SimonCropp/MarkdownSnippets) from 10.3.0 to 12.0.3.
- [Release notes](https://github.com/SimonCropp/MarkdownSnippets/releases)
- [Commits](https://github.com/SimonCropp/MarkdownSnippets/commits)

Signed-off-by: dependabot-preview[bot] <[email protected]>

* Bump PublicApiGenerator from 9.0.0 to 9.1.0 in /src (#121)

Bumps [PublicApiGenerator](https://github.com/JakeGinnivan/ApiApprover) from 9.0.0 to 9.1.0.
- [Release notes](https://github.com/JakeGinnivan/ApiApprover/releases)
- [Commits](PublicApiGenerator/PublicApiGenerator@9.0.0...9.1.0)

Signed-off-by: dependabot-preview[bot] <[email protected]>

* Bump Microsoft.NET.Test.Sdk from 16.1.0 to 16.2.0 in /src (#119)

Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.1.0 to 16.2.0.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](microsoft/vstest@v16.1.0...v16.2.0)

Signed-off-by: dependabot-preview[bot] <[email protected]>

* Bump Microsoft.SourceLink.GitHub from 1.0.0-beta2-19270-01 to 1.… (#125)

Bumps [Microsoft.SourceLink.GitHub](https://github.com/dotnet/sourcelink) from 1.0.0-beta2-19270-01 to 1.0.0-beta2-19367-01.
- [Release notes](https://github.com/dotnet/sourcelink/releases)
- [Commits](dotnet/sourcelink@1.0.0-beta2-19270-01...1.0.0-beta2-19367-01)

Signed-off-by: dependabot-preview[bot] <[email protected]>

* Bump MarkdownSnippets from 12.0.3 to 14.0.0 in /src (#128)

Bumps [MarkdownSnippets](https://github.com/SimonCropp/MarkdownSnippets) from 12.0.3 to 14.0.0.
- [Release notes](https://github.com/SimonCropp/MarkdownSnippets/releases)
- [Commits](https://github.com/SimonCropp/MarkdownSnippets/commits/14.0.0)

Signed-off-by: dependabot-preview[bot] <[email protected]>

* Bump PublicApiGenerator from 9.1.0 to 9.3.0

* Bump MarkdownSnippets from 14.0.0 to 16.2.0

* Include README.source.md in the solution

* Generate TOC

* Bump MarkdownSnippets from 16.2.0 to 16.3.1 in /src (#139)

Bumps [MarkdownSnippets](https://github.com/SimonCropp/MarkdownSnippets) from 16.2.0 to 16.3.1.
- [Release notes](https://github.com/SimonCropp/MarkdownSnippets/releases)
- [Commits](https://github.com/SimonCropp/MarkdownSnippets/commits)

Signed-off-by: dependabot-preview[bot] <[email protected]>

* Bump MarkdownSnippets from 16.3.1 to 16.5.0 in /src (#143)

Bumps [MarkdownSnippets](https://github.com/SimonCropp/MarkdownSnippets) from 16.3.1 to 16.5.0.
- [Release notes](https://github.com/SimonCropp/MarkdownSnippets/releases)
- [Commits](https://github.com/SimonCropp/MarkdownSnippets/commits)

Signed-off-by: dependabot-preview[bot] <[email protected]>

* Bump Microsoft.Azure.ServiceBus from 2.0.0 to 4.1.0 in /src (#144)

Bumps [Microsoft.Azure.ServiceBus](https://github.com/Azure/azure-sdk-for-net) from 2.0.0 to 4.1.0.
- [Release notes](https://github.com/Azure/azure-sdk-for-net/releases)
- [Commits](Azure/azure-sdk-for-net@Microsoft.Azure.Management.Kusto_2.0.0...Microsoft.Azure.ServiceBus_4.1.0)

Signed-off-by: dependabot-preview[bot] <[email protected]>

* Switch to the new version of Azure Storage library. Fixes #116

* Remove obsoleted with error API. Fixes #99

* Remove overloads taking a specific client that are not needed. Fixes #115

* Switch image, test on .NET Core 3.0

* Package license file and icon

* Enable nullables

* Update testing libraries

* Approve API

* Use `= default` consistently

* Move `Nullable` to Directory.Build.props

* Remove redundant item

* Fix nullable references for the test project

* Use `= default` consistently

* Bump Microsoft.SourceLink.GitHub in /src (#147)

Bumps [Microsoft.SourceLink.GitHub](https://github.com/dotnet/sourcelink) from 1.0.0-beta2-19367-01 to 1.0.0-beta2-19554-01.
- [Release notes](https://github.com/dotnet/sourcelink/releases)
- [Commits](dotnet/sourcelink@1.0.0-beta2-19367-01...1.0.0-beta2-19554-01)

Signed-off-by: dependabot-preview[bot] <[email protected]>

* Prepare release 6.0.0
@SeanFeldman
Copy link
Owner Author

@CasperWSchmidt AttachmentPlugin 6.0.0 and ServiceBus.AttachmentPlugin.KeyVaultProvider 3.0.0 are out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants