Fix for Container.CreateIfNotExist HTTP status 409 #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correcting an error in the storage client when CreateIfNotExists sometimes returns 409 status
SeanFeldman
requested changes
Aug 7, 2018
There was a problem hiding this comment.
Thank you @odysseus1973
Good catch!
Please see my comments. Once those are addressed, this is good to go (I'll backport and release a patch).
| @@ -48,7 +48,11 @@ public override async Task<Message> BeforeMessageSend(Message message) | |||
| await InitializeClient().ConfigureAwait(false); | |||
|
|
|||
| var container = client.GetContainerReference(configuration.ContainerName); | |||
| await container.CreateIfNotExistsAsync().ConfigureAwait(false); | |||
|
|
|||
| if (! await container.ExistsAsync()) | |||
There was a problem hiding this comment.
.ConfigureAwait(false) is missing
| @@ -139,7 +143,11 @@ public override async Task<Message> AfterMessageReceive(Message message) | |||
| await InitializeClient().ConfigureAwait(false); | |||
|
|
|||
| var container = client.GetContainerReference(configuration.ContainerName); | |||
| await container.CreateIfNotExistsAsync().ConfigureAwait(false); | |||
|
|
|||
| if (! await container.ExistsAsync()) | |||
There was a problem hiding this comment.
.ConfigureAwait(false) is missing
SeanFeldman
changed the title
SeanFeldman
approved these changes
Aug 7, 2018
|
Thank you @odysseus1973 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CreateIfNotExists()can fail with code 409 which represents more than one state (similar to Tables)TableAlreadyExistsorTableBeingDeletedThis is an issue with the Storage Table SDK with a workaround implemented in this PR.
Original description
Correcting an error in the storage client when CreateIfNotExists sometimes returns 409 status