Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix browser on Pharo 13 #1424

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Fix browser on Pharo 13 #1424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions ...itory/Seaside-Pharo-Development.package/WARPackageBasedBrowser.class/instance/packages.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
private
packages
| rPackage |
rPackage := Smalltalk at: #RPackage.
^ ((rPackage respondsTo: #packageOrganizer)
ifTrue: [ rPackage packageOrganizer ]
ifFalse: [ rPackage organizer ]) packages
^ (Smalltalk hasClassNamed: #RPackage)
ifTrue: [
| rPackage |
rPackage := Smalltalk at: #RPackage.
((rPackage respondsTo: #packageOrganizer)
ifTrue: [ rPackage packageOrganizer ]
ifFalse: [ rPackage organizer ]) packages ]
ifFalse: [ PackageOrganizer default packages ]
4 changes: 3 additions & 1 deletion ...Seaside-Pharo-Development.package/WARPackageBasedBrowser.class/instance/parentOfClass..st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@
| package tag |

package := aClass package.
tag := package classTagForClass: aClass.
tag := (package respondsTo: #classTagForClass:)
ifTrue: [ package perform: #classTagForClass: with: aClass ]
ifFalse: [ package perform: #tagOf: with: aClass ].

Check warning on line 12 in repository/Seaside-Pharo-Development.package/WARPackageBasedBrowser.class/instance/parentOfClass..st

View check run for this annotation

Codecov / codecov/patch

repository/Seaside-Pharo-Development.package/WARPackageBasedBrowser.class/instance/parentOfClass..st#L10-L12 

Added lines #L10 - L12 were not covered by tests

^ (((tag name = package name) and: [ package classTags size <= 1 ]) or: [ tag isNil ])
ifTrue: [ package ]
Expand Down
Loading