Create first version of dashboard closes #95 #114 #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kordc
reviewed
Oct 3, 2023
art/dashboard/ideal_logs/AlreadyExistingSolutionBaseline_3_Evaluate Baseline/log.txt
Outdated
Show resolved
Hide resolved
kordc
reviewed
Oct 21, 2023
kordc
reviewed
Oct 21, 2023
kordc
reviewed
Oct 21, 2023
kordc
reviewed
Oct 21, 2023
SebChw
force-pushed
the
develop_dashboard
branch
from
844594e to
ab52af4
Compare
kordc
reviewed
Nov 2, 2023
art/dashboard/layout.py
Outdated
| from art.dashboard.help import HELP | ||
|
|
||
| RADIUS_AROUND = {"border-radius": "25px", "border": "2px solid #a87332"} | ||
| PAD = {"padding": "15px"} |
There was a problem hiding this comment.
Could we move those 2 consts to const.py?
art/dashboard/backend.py
Outdated
|
|
||
|
|
||
| def prepare_steps(logs_path): | ||
| # TODO to order which steps were first is another issue for me. Should we stick to the integer inside a directory name? |
There was a problem hiding this comment.
Convert it to issue if you won't solve it in this PR
art/dashboard/app.py
Outdated
| selected_params = {key: samples[selected_row][key] for key in parameters} | ||
| for row in samples: | ||
| if row["index"] == selected_row: | ||
| params = parameters |
There was a problem hiding this comment.
These names params and parameters are a bit confusing. I'm a fan of self-explaining vars' names which would differentiate between both, but it's only a suggestion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please reed #95 and #114 to know what problems this PR solves
I tried to do it few times and the 3rd approach somehow succeed.
refactor to current log format This commit implements actual version of the dashboard. You can omit previous ones.
See
readme.mdfor the instructions of running dashboard