Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data analysis #118

Merged
merged 2 commits into from
Oct 15, 2023
Merged

data analysis #118

merged 2 commits into from
Oct 15, 2023

Conversation

trebacz626
Copy link
Collaborator

No description provided.

@trebacz626 trebacz626 requested review from SebChw, kordc and mmaecki October 8, 2023 11:40
@kordc
Copy link
Collaborator

kordc commented Oct 8, 2023

LGTM

kordc
kordc previously approved these changes Oct 8, 2023
Copy link
Collaborator

@kordc kordc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SebChw
Copy link
Owner

SebChw commented Oct 10, 2023

I am not a fan of too deep inharitance, but in this case this Step -> ModelStep seems reasonable

SebChw
SebChw previously approved these changes Oct 14, 2023
mmaecki
mmaecki previously approved these changes Oct 14, 2023
@kordc kordc dismissed stale reviews from mmaecki, SebChw, and themself via d27411d October 15, 2023 17:50
@kordc kordc merged commit 5c601a9 into develop Oct 15, 2023
@kordc kordc deleted the data_analysis_final branch October 15, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants