Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Continous Integration #12

Merged
merged 5 commits into from
Mar 17, 2023
Merged

Add Continous Integration #12

merged 5 commits into from
Mar 17, 2023

Conversation

SebChw
Copy link
Owner

@SebChw SebChw commented Mar 14, 2023

closes #10

@kordc
Copy link
Collaborator

kordc commented Mar 14, 2023

nice, maybe before flake8 we should add black/autopep8?
autopep8 is default in VSC https://code.visualstudio.com/docs/python/editing#_general-formatting-settings

@SebChw
Copy link
Owner Author

SebChw commented Mar 15, 2023

@kordc what do you mean? You want the code to be formatted automatically when pushed? If yes, I'd rather people formatted code by themselves to be aware of this.

@kordc
Copy link
Collaborator

kordc commented Mar 15, 2023

@SebChw yep, I meant that. But fair enough, not a necessary thing to do. If so, the rest LGTM

@SebChw
Copy link
Owner Author

SebChw commented Mar 17, 2023

@kordc If we do this people won't know that they wrote badly formatted code, that's why I don't want to do so.

@SebChw SebChw merged commit f02f0f7 into main Mar 17, 2023
@SebChw SebChw deleted the sebchw-add-ci branch April 4, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configue CI
2 participants