Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kcyganik change ckpt art folder #166

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Kcyganik change ckpt art folder #166

merged 1 commit into from
Nov 21, 2023

Conversation

kordc
Copy link
Collaborator

@kordc kordc commented Nov 19, 2023

@kordc kordc requested review from trebacz626 and SebChw November 19, 2023 11:57
@kordc kordc changed the base branch from main to develop November 19, 2023 11:57
SebChw
SebChw requested changes Nov 19, 2023
View reviewed changes
Copy link
Owner

@SebChw SebChw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just resolve conflicts and remove art_art from test_files.txt

tests/utils/test_files.txt Outdated
checkpoints/data_analysis_Data analysis/class_images/class_7.png
checkpoints/data_analysis_Data analysis/class_images/class_8.png
checkpoints/data_analysis_Data analysis/class_images/class_9.png
art_art_checkpoints/data_analysis_Data analysis/class_images/class_0.png
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably too many arts

@kordc
change art checkpoints folder name
5a84767 
It's because checkpoints folder could be used by the users for their
purposes. art_checkpoints won't create any confusion
@kordc kordc force-pushed the kcyganik-change-ckpt-art-folder branch from e2286ef to 5a84767 Compare November 21, 2023 11:18
@SebChw SebChw merged commit 30dc2bf into develop Nov 21, 2023
@SebChw SebChw deleted the kcyganik-change-ckpt-art-folder branch November 21, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebChw SebChw SebChw approved these changes

@trebacz626 trebacz626 Awaiting requested review from trebacz626

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kordc @SebChw