default force rerun to false #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we're talking about it several times before I propose this solution. For now even when we add an extra info to the logger all steps will be re-run. As we provide the rerun flag I thik it'd be beneficial for everyone of we default the rerun to false and just infor the user about the need of the rerun when the model code was changed. If you feel differently feel free to open the discussion below #155
|
I completely agree. Just inform that they should rerun it |
SebChw
requested changes
Nov 19, 2023
art/project.py
Outdated
| @@ -162,25 +162,23 @@ def check_if_must_be_run(self, step: "Step", checks: List[Check]) -> bool: | |||
| Returns: | |||
| bool: True if the step must be run, False otherwise. | |||
| """ | |||
| step_current_hash = step.get_hash() | |||
| step_saved_hash = step.get_latest_run()["hash"] | |||
There was a problem hiding this comment.
How can we get_latest_run if step was not run? I'd put this below
art/project.py
Outdated
| if not step.was_run(): | ||
| return True | ||
| return True, model_changed |
There was a problem hiding this comment.
If step was not run how can model even change. I'd return False by default
art/project.py
Outdated
| if not step.was_run(): | ||
| return True | ||
| return True, model_changed | ||
| else: | ||
| try: | ||
| self.check_checks(step, checks) | ||
| except Exception as e: |
There was a problem hiding this comment.
I know you didn't change it but we should catch CheckFailedException
art/project.py
Outdated
| @@ -191,13 +189,18 @@ def run_all(self, force_rerun=False): | |||
| """ | |||
| run_id = get_run_id() | |||
| logger_id = add_logger(EXPERIMENT_LOG_DIR / get_new_log_file_name(run_id)) | |||
| changed_steps = [] | |||
There was a problem hiding this comment.
I think this function shouldn't be responsible for collecting changed_steps. I'd create self.changed_steps and make changes inside check_if_must_be_run
art/project.py
Outdated
| @@ -215,14 +218,14 @@ def run_all(self, force_rerun=False): | |||
| self.fill_step_states(step) | |||
| step.save_to_disk() | |||
|
|
|||
| self.print_summary() | |||
| self.print_summary(changed_steps) | |||
There was a problem hiding this comment.
Same here I wouldn't require parameter to be passed. Print summary can be aware of changed steps
SebChw
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we're talking about it several times before I propose this solution. For now even when we add an extra info to the logger all steps will be re-run. As we provide the rerun flag I thik it'd be beneficial for everyone of we default the rerun to false and just infor the user about the need of the rerun when the model code was changed.
If you feel differently feel free to open the discussion below
#155