Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quickstart solves #190 #163 #186

Merged
merged 13 commits into from
Nov 25, 2023
Merged

Quickstart solves #190 #163 #186

merged 13 commits into from
Nov 25, 2023

Conversation

kordc
Copy link
Collaborator

@kordc kordc commented Nov 24, 2023

add quickstart modules - As suggested. I placed few Dummy modules inside art now quickstart work withouth any additional effort.
organize tests - Since I wanted to write another test for quickstart I made thing reusable

allow custom metric name inside check, make checks optional,
make log params optional - These doesn't break logic of ART and everything written before works. I just thougt that someone Could potentially cherrypick only some features of ART

make metric calculator optional - This is for someone that just want to wrap their lightning modules with steps and checks. Unfortunatelly this required a little bit effort. I put entire metric calculator handling on the step side as now it can be None

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@SebChw SebChw marked this pull request as ready for review November 25, 2023 11:17
@SebChw SebChw changed the title Quickstart Quickstart solves #190 #163 Nov 25, 2023
trebacz626
trebacz626 previously approved these changes Nov 25, 2023
@kordc kordc merged commit 333ce9a into develop Nov 25, 2023
1 check failed
@kordc kordc deleted the quickstart branch November 25, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants