Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor regularization step closes #117 #200

Merged
merged 18 commits into from
Dec 2, 2023
Merged

Refactor regularization step closes #117 #200

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
6521d24
get rid off turn_on/off regularization
SebChw Nov 29, 2023
930a8de
add datamodule modifiers
SebChw Nov 30, 2023
848f4a1
reduce dependencies
SebChw Nov 30, 2023
87adae3
add access to current stage for ArtModule
SebChw Dec 1, 2023
78c5de2
remove unused exceptions
SebChw Dec 1, 2023
3177ae1
add utils for orange logs
SebChw Dec 1, 2023
1ef112f
add utils for building metric name
SebChw Dec 1, 2023
cc0a0ff
add possibility for the step to decide when it should be run or not
SebChw Dec 1, 2023
ad90ba6
separate model and data logs
SebChw Dec 1, 2023
b964dec
rewrite regularizaton
SebChw Dec 1, 2023
522c858
add class fields
SebChw Dec 1, 2023
a221c60
adjust dashboard
SebChw Dec 1, 2023
2e7b764
formatting changes
SebChw Dec 1, 2023
27ed200
add new tutorial
SebChw Dec 1, 2023
d27f233
remove log model params from base Step
SebChw Dec 1, 2023
e49f11a
remove log params completely from base Step
SebChw Dec 1, 2023
6dd2fdc
add regularize tutorial
SebChw Dec 1, 2023
af127da
fix jupyter tutorial
SebChw Dec 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions art/steps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,14 @@

from art.core import ArtModule
from art.decorators import ModelDecorator, art_decorate
from art.loggers import (add_logger, art_logger, get_new_log_file_name,
get_run_id, log_yellow_warning, remove_logger)
from art.loggers import (
kordc marked this conversation as resolved.
Show resolved Hide resolved
add_logger,
art_logger,
get_new_log_file_name,
get_run_id,
log_yellow_warning,
remove_logger,
)
from art.metrics import MetricCalculator, SkippedMetric
from art.utils.enums import TrainingStage
from art.utils.paths import get_checkpoint_logs_folder_path
Expand Down Expand Up @@ -162,12 +168,6 @@ def set_successful(self):
def is_successful(self):
return self.results["successful"]

@abstractmethod
def log_model_params(
self,
):
pass

@abstractmethod
def log_data_params(self):
pass
Expand Down