Fixing some issues closes #64, closes #62 #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trebacz626
reviewed
Sep 9, 2023
trebacz626
reviewed
Sep 9, 2023
trebacz626
reviewed
Sep 9, 2023
| @@ -36,3 +35,6 @@ def _get_saved_state(self) -> Dict[str, str]: | |||
|
|
|||
| def get_saved_state(self) -> Dict[str, str]: | |||
| return {} | |||
|
|
|||
| def get_step_id(self) -> str: | |||
There was a problem hiding this comment.
I do not think that steps should have different names based on which datamodule or model was used. Maybe for different model we should just do it in a different folder
trebacz626
reviewed
Sep 9, 2023
art/step/step.py
Outdated
|
|
||
| def __call__(self, previous_states: List[Dict]): | ||
| ExperimentState.current_stage = TrainingStage.TRAIN # TODO: Some steps need to do this during execution time | ||
| ExperimentState.current_stage = TrainingStage.TRAIN |
There was a problem hiding this comment.
I like the stage idea for now, but need to dive deeper.
Experiment state
This was referenced Sep 26, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All issues solved beside the one defined on git are marked with DONE here
After I obtain LGTM from someone Ill try to adapt art template to it