Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EoL for Node14 and 17 #177

Closed
4 of 5 tasks
Secreto31126 opened this issue Jul 17, 2023 · 1 comment
Closed
4 of 5 tasks

EoL for Node14 and 17 #177

Secreto31126 opened this issue Jul 17, 2023 · 1 comment

Comments

@Secreto31126
Copy link
Owner

Secreto31126 commented Jul 17, 2023

The library should be updated to reflect the deprecated Node versions, specially in the setup/node.ts file.

Also, I think it would be nice to plan the v2 release to match with node16 EoL on September, 11.

Things to do for a still tbd v2:

  • Set package.json engine to ">=18"
  • Update Catalog message support #168 monkey patch
  • Update src/setup/node.ts to only support @^18 Deprecate node 16 method on src/setup/node.ts
  • Update github actions
  • Maaaaabye consider removing CommonJS support (although I'm happy with the results I got with esbuild)
@hys-oc
Copy link

hys-oc commented Jul 21, 2023

Great library, some things on the examples are a bit confusing, would recommend to add how you import everything on the examples since you kinda have to deduct from where to import it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants