Catalog message support #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catalog interactive messages
Kind of Unfortunately, WhatsApp renamed a few names related to products, and now I had to create this literal monkey patch to deal with both backwards compatibility and future proof the code
|
Visit the preview URL for this PR (updated for commit 63504f9): https://whatsappapijs--pr168-catalog-message-63ch2v51.web.app (expires Tue, 01 Aug 2023 20:38:12 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 80a8dc4ceea5c783aae1d47b75797ee5b6c2f4be |
Now it seems to work... mostly The API sends the message, but there's an issue on the app when trying to open the catalog saying "The catalog couldn't be found"
I wonder who will use this 👀... Looking at you, template-modularization
I never liked MonkeyPatch
Moved types to messages/index.ts, as it makes more sense there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
npm run testand lint the project withnpm run lintandnpm run prettierAdded Catalog Messages support, while preserving products messages backward compatibility and hopefully make it easy to fix when v2 comes.
Btw, the code doesn't work. Seems like I wrote it too early, even before the API supports it 😄