Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esbuild fix #203

Merged
merged 6 commits into from
Aug 31, 2023
Merged

esbuild fix #203

merged 6 commits into from
Aug 31, 2023

Conversation

Secreto31126
Copy link
Owner

@Secreto31126 Secreto31126 commented Aug 20, 2023

This will be a really painful issue to solve. I can't reorder the commits and create the tag in the past, so the best bet should be marking this branch as 1.0.4 1.0.5, creating the release, lose the package.json change and merging to master.

This is why you must not merge pull requests to master while working on a breaking update, I hope I learnt the lesson by now.

Closes #198

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm run test and lint the project with npm run lint and npm run prettier

Fixed an issue introduced in esbuild v18
This single change will be the most painfull to merge
Thanks to the new white box unit tests for most of the messages.
@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 9bbf30e):

https://whatsappapijs--pr203-esbuild-fix-zl7oqtqm.web.app

(expires Thu, 07 Sep 2023 22:03:49 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 80a8dc4ceea5c783aae1d47b75797ee5b6c2f4be

@Secreto31126 Secreto31126 merged commit eb8a866 into main Aug 31, 2023
@Secreto31126 Secreto31126 deleted the esbuild-fix branch August 31, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error sending message: Error: Header image must not have a caption
1 participant