Replace mocha with Node's test suit #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now we can test esm code safely. Plus, the native tests detect way more bugs than mocha, such as missing awaits and similars, so really happy with the change :]
|
Visit the preview URL for this PR (updated for commit 05f639a): https://whatsappapijs--pr391-drop-mocha-hrvyn86k.web.app (expires Thu, 26 Dec 2024 23:33:28 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 80a8dc4ceea5c783aae1d47b75797ee5b6c2f4be |
|
What if we also drop Node 18? I mean, Undici already did, so... |
|
Seems like Node 18 will last a few more months |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
npm run testand lint the project withnpm run lintandnpm run prettierMocha has a weird support for ESM. If we want to drop CJS support, the tests also need to be ESM.
The PR replaces Mocha with the native NodeJS test suit, which although "experimental", it works really nice.