Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed nested message stringify #393

Merged
merged 2 commits into from
Dec 31, 2024
Merged

Removed nested message stringify #393

merged 2 commits into from
Dec 31, 2024

Conversation

Secreto31126
Copy link
Owner

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm run test and lint the project with npm run lint and npm run prettier

With this new structure, ClientMessageRequest is fully typed and will probably be faster to send messages as JSON.stringify is called less times.

Closes #374

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
kianenigma Kian Paimani
Also discovered the toJSON method, so _build is no longer needed

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link

Visit the preview URL for this PR (updated for commit f3a5a74):

https://whatsappapijs--pr393-no-stringify-op7gzrvq.web.app

(expires Tue, 07 Jan 2025 16:30:38 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 80a8dc4ceea5c783aae1d47b75797ee5b6c2f4be

@Secreto31126 Secreto31126 merged commit c8befb6 into main Dec 31, 2024
8 checks passed
@Secreto31126 Secreto31126 deleted the no-stringify branch December 31, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClientMessageRequest has incomplete types, why?
1 participant