Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to avoid tox test setup failures in unit-tests and test-setup CI jobs #429

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

dkg
Copy link
Contributor

@dkg dkg commented Feb 6, 2023

I'm seeing errors like this in the test-setup and unit-tests CI jobs:

py: failed with pass_env values cannot contain whitespace, use comma to have multiple values in a single line, invalid values found 'HOME ARCHFLAGS LDFLAGS CFLAGS INCLUDE LIB LD_LIBRARY_PATH PATH'

and:

py39-setup: failed with pass_env values cannot contain whitespace, use comma to have multiple values in a single line, invalid values found 'HOME ARCHFLAGS LDFLAGS CFLAGS INCLUDE LIB LD_LIBRARY_PATH PATH'

Despite the fact that tox documentation says that "passenv" is "SPACE-SEPARATED-GLOBNAMES", the setup seems to think that "pass_env" (which is not "passenv", note the lack of underscore) is somehow bad. Maybe putting each value on its own line will satisfy this check?

…jobs

I'm seeing errors like this in the test-setup and unit-tests CI jobs:

py: failed with pass_env values cannot contain whitespace, use comma to have multiple values in a single line, invalid values found 'HOME ARCHFLAGS LDFLAGS CFLAGS INCLUDE LIB LD_LIBRARY_PATH PATH'

py39-setup: failed with pass_env values cannot contain whitespace, use comma to have multiple values in a single line, invalid values found 'HOME ARCHFLAGS LDFLAGS CFLAGS INCLUDE LIB LD_LIBRARY_PATH PATH'

Despite the fact that [tox
documentation](https://tox.wiki/en/3.1.2/config.html) says that
"passenv" is "SPACE-SEPARATED-GLOBNAMES", the setup seems to think
that "pass_env" (which is not "passenv", note the lack of underscore)
is somehow bad.  Maybe putting each value on its own line will satisfy
this check?
@dkg
Copy link
Contributor Author

dkg commented Feb 6, 2023

this appears to have been a successful workaround. the remaining failures appear to be network timeouts.

I recommend merging this to get the CI back on track.

@dkg
Copy link
Contributor Author

dkg commented Mar 13, 2023

please consider merging this to get the CI back in shape. I have several patches pending that i'd love to rebase on top of this fix so i can submit them as proper merge requests.

@Commod0re Commod0re merged commit 30a7571 into SecurityInnovation:master Mar 14, 2023
@Commod0re
Copy link
Contributor

@dkg dkg deleted the cleanup-tox branch June 14, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants