Merge pull request #921 from SeedCompany/917-create-project-duplicati…

…on-error Throw duplication exception while creating with same project name
SeedCompany · Aug 10, 2020 · 57372fc · 57372fc
2 parents cd822c5 + 3bcc0c1
commit 57372fc
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 7 deletions.
diff --git a/src/components/engagement/engagement.service.ts b/src/components/engagement/engagement.service.ts
@@ -270,7 +270,12 @@ export class EngagementService {
     // Initial LanguageEngagement
     const id = generate();
     const createdAt = DateTime.local();
-    const pnp = await this.files.createDefinedFile(`PNP`, session, input.pnp, 'engagement.pnp');
+    const pnp = await this.files.createDefinedFile(
+      `PNP`,
+      session,
+      input.pnp,
+      'engagement.pnp'
+    );
 
     const ceremony = await this.ceremonyService.create(
       { type: CeremonyType.Dedication },
@@ -1016,7 +1021,12 @@ export class EngagementService {
       session
     )) as LanguageEngagement;
 
-    await this.files.updateDefinedFile(object.pnp, 'engagement.pnp', pnp, session);
+    await this.files.updateDefinedFile(
+      object.pnp,
+      'engagement.pnp',
+      pnp,
+      session
+    );
 
     try {
       await this.db.sgUpdateProperties({
@@ -1060,7 +1070,12 @@ export class EngagementService {
       session
     )) as InternshipEngagement;
 
-    await this.files.updateDefinedFile(object.growthPlan, 'engagement.growthPlan', growthPlan, session);
+    await this.files.updateDefinedFile(
+      object.growthPlan,
+      'engagement.growthPlan',
+      growthPlan,
+      session
+    );
 
     try {
       if (mentorId) {
@@ -1161,10 +1176,7 @@ export class EngagementService {
       throw new ServerException('Could not find update InternshipEngagement');
     }
 
-    return (await this.readOne(
-      input.id,
-      session
-    )) as InternshipEngagement;
+    return (await this.readOne(input.id, session)) as InternshipEngagement;
   }
 
   // DELETE /////////////////////////////////////////////////////////

diff --git a/src/components/project/project.service.ts b/src/components/project/project.service.ts
@@ -3,6 +3,7 @@ import { node, relation } from 'cypher-query-builder';
 import { flatMap, upperFirst } from 'lodash';
 import { DateTime } from 'luxon';
 import {
+  DuplicateException,
   fiscalYears,
   InputException,
   ISession,
@@ -29,6 +30,7 @@ import {
   OnIndex,
   Property,
   runListQuery,
+  UniquenessError,
 } from '../../core';
 import {
   Budget,
@@ -375,6 +377,12 @@ export class ProjectService {
 
       return project;
     } catch (e) {
+      if (e instanceof UniquenessError && e.label === 'ProjectName') {
+        throw new DuplicateException(
+          'project.name',
+          'Project with this name already exists'
+        );
+      }
       this.logger.warning(`Could not create project`, {
         exception: e,
       });