Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue caused by having is_sign_message method and property of same name #578

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Fix issue caused by having is_sign_message method and property of same name #578

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions src/seedsigner/models/decode_qr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ def detect_segment_type(s, wordlist_language_code=None):
return QRType.BITCOIN_ADDRESS

# message signing
elif DecodeQR.is_sign_message(s):
elif s.startswith("signmessage"):
return QRType.SIGN_MESSAGE

# config data
Expand Down Expand Up @@ -506,11 +506,6 @@ def is_bitcoin_address(s):
return False


@staticmethod
def is_sign_message(s):
return type(s) == str and s.startswith("signmessage")


@staticmethod
def multisig_setup_file_to_descriptor(text) -> str:
# sample text file, parse the contents and create descriptor
Expand Down
Loading