Skip to content

Commit

Permalink
Merge pull request #3239 from cliveseldon/notebook_istio_port
Browse files Browse the repository at this point in the history
update notebooks to use port 8080 for istio
  • Loading branch information
ukclivecox authored May 28, 2021
2 parents 98e7dec + 9f91223 commit 60776b3
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 14 deletions.
2 changes: 1 addition & 1 deletion notebooks/backwards_compatability.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"Then port-forward to that ingress on localhost:8003 in a separate terminal either with:\n",
"\n",
" * Ambassador: `kubectl port-forward $(kubectl get pods -n seldon -l app.kubernetes.io/name=ambassador -o jsonpath='{.items[0].metadata.name}') -n seldon 8003:8080`\n",
" * Istio: `kubectl port-forward $(kubectl get pods -l istio=ingressgateway -n istio-system -o jsonpath='{.items[0].metadata.name}') -n istio-system 8003:80`"
" * Istio: `kubectl port-forward $(kubectl get pods -l istio=ingressgateway -n istio-system -o jsonpath='{.items[0].metadata.name}') -n istio-system 8003:8080`"
]
},
{
Expand Down
2 changes: 1 addition & 1 deletion notebooks/istio_example.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.8.3"
"version": "3.6.8"
},
"varInspector": {
"cols": {
Expand Down
18 changes: 9 additions & 9 deletions notebooks/protocol_examples.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"Then port-forward to that ingress on localhost:8003 in a separate terminal either with:\n",
"\n",
" * Ambassador: `kubectl port-forward $(kubectl get pods -n seldon -l app.kubernetes.io/name=ambassador -o jsonpath='{.items[0].metadata.name}') -n seldon 8003:8080`\n",
" * Istio: `kubectl port-forward $(kubectl get pods -l istio=ingressgateway -n istio-system -o jsonpath='{.items[0].metadata.name}') -n istio-system 8003:80`"
" * Istio: `kubectl port-forward $(kubectl get pods -l istio=ingressgateway -n istio-system -o jsonpath='{.items[0].metadata.name}') -n istio-system 8003:8080`"
]
},
{
Expand Down Expand Up @@ -56,7 +56,7 @@
"name": "stdout",
"output_type": "stream",
"text": [
"Context \"kind-ansible\" modified.\r\n"
"Context \"gke_seldon-demos_europe-west1-c_core\" modified.\r\n"
]
}
],
Expand Down Expand Up @@ -96,7 +96,7 @@
{
"data": {
"text/plain": [
"'1.8.0-dev'"
"'1.9.0-dev'"
]
},
"execution_count": 5,
Expand Down Expand Up @@ -126,7 +126,7 @@
},
{
"cell_type": "code",
"execution_count": 6,
"execution_count": 7,
"metadata": {},
"outputs": [],
"source": [
Expand All @@ -152,7 +152,7 @@
},
{
"cell_type": "code",
"execution_count": 7,
"execution_count": 8,
"metadata": {},
"outputs": [
{
Expand All @@ -169,7 +169,7 @@
},
{
"cell_type": "code",
"execution_count": 8,
"execution_count": 9,
"metadata": {},
"outputs": [
{
Expand All @@ -187,7 +187,7 @@
},
{
"cell_type": "code",
"execution_count": 9,
"execution_count": 10,
"metadata": {},
"outputs": [
{
Expand Down Expand Up @@ -218,7 +218,7 @@
"name": "stdout",
"output_type": "stream",
"text": [
"{'data': {'names': ['proba'], 'ndarray': [[0.43782349911420193]]}, 'meta': {'requestPath': {'classifier': 'seldonio/mock_classifier:1.6.0-dev'}}}\n"
"{'data': {'names': ['proba'], 'ndarray': [[0.43782349911420193]]}, 'meta': {'requestPath': {'classifier': 'seldonio/mock_classifier:1.9.0-dev'}}}\n"
]
}
],
Expand All @@ -240,7 +240,7 @@
"name": "stdout",
"output_type": "stream",
"text": [
"{'meta': {'requestPath': {'classifier': 'seldonio/mock_classifier:1.6.0-dev'}}, 'data': {'names': ['proba'], 'ndarray': [[0.43782349911420193]]}}\n"
"{'meta': {'requestPath': {'classifier': 'seldonio/mock_classifier:1.9.0-dev'}}, 'data': {'names': ['proba'], 'ndarray': [[0.43782349911420193]]}}\n"
]
}
],
Expand Down
4 changes: 2 additions & 2 deletions notebooks/scale.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"Then port-forward to that ingress on localhost:8003 in a separate terminal either with:\n",
"\n",
" * Ambassador: `kubectl port-forward $(kubectl get pods -n seldon -l app.kubernetes.io/name=ambassador -o jsonpath='{.items[0].metadata.name}') -n seldon 8003:8080`\n",
" * Istio: `kubectl port-forward $(kubectl get pods -l istio=ingressgateway -n istio-system -o jsonpath='{.items[0].metadata.name}') -n istio-system 8003:80`"
" * Istio: `kubectl port-forward $(kubectl get pods -l istio=ingressgateway -n istio-system -o jsonpath='{.items[0].metadata.name}') -n istio-system 8003:8080`"
]
},
{
Expand Down Expand Up @@ -398,7 +398,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.7.4"
"version": "3.6.8"
}
},
"nbformat": 4,
Expand Down
2 changes: 1 addition & 1 deletion notebooks/triton_examples.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
" Then port-forward to that ingress on localhost:8003 in a separate terminal either with:\n",
"\n",
" * Ambassador: `kubectl port-forward $(kubectl get pods -n seldon -l app.kubernetes.io/name=ambassador -o jsonpath='{.items[0].metadata.name}') -n seldon 8003:8080`\n",
" * Istio: `kubectl port-forward $(kubectl get pods -l istio=ingressgateway -n istio-system -o jsonpath='{.items[0].metadata.name}') -n istio-system 8003:80`\n",
" * Istio: `kubectl port-forward $(kubectl get pods -l istio=ingressgateway -n istio-system -o jsonpath='{.items[0].metadata.name}') -n istio-system 8003:8080`\n",
"\n",
"### Create Namespace for experimentation\n",
"\n",
Expand Down

0 comments on commit 60776b3

Please sign in to comment.