Merge pull request #2435 from cliveseldon/mlops

Update seldon-single-model
SeldonIO · Sep 17, 2020 · 9806b5d · 9806b5d
2 parents f63804a + 9077b9c
commit 9806b5d
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 1 deletion.
diff --git a/helm-charts/seldon-single-model/templates/seldondeployment.json b/helm-charts/seldon-single-model/templates/seldondeployment.json
@@ -11,7 +11,9 @@
     }
   },
   "spec": {
-    "name": "{{ .Release.Name }}",
+      "name": "{{ .Release.Name }}",
+      "protocol": "{{ .Values.protocol }}",
+      "transport": "{{ .Values.transport }}",      
     "annotations": {
       {{- range $name, $val := .Values.annotations }}
         "{{ $name }}": "{{ $val }}",
@@ -25,9 +27,21 @@
           {{- if .Values.model.implementation }}
           "implementation": "{{ .Values.model.implementation }}",
           {{- end}}
+          {{- if .Values.model.envSecretRefName }}
+          "envSecretRefName": "{{ .Values.model.envSecretRefName }}",
+          {{- end}}
           {{- if .Values.model.uri }}
           "modelUri": "{{ .Values.model.uri }}",
           {{- end}}
+          {{- if .Values.model.mlflow.xtype }}
+          "parameters": [
+		{
+		    "name": "xtype",
+		    "type": "STRING",
+		    "value": "{{ .Values.model.mlflow.xtype }}" 
+		}
+	  ],
+          {{- end}}
           "type": "MODEL",
           {{- if .Values.model.logger.enabled }}
           "logger": {

diff --git a/helm-charts/seldon-single-model/values.yaml b/helm-charts/seldon-single-model/values.yaml
@@ -1,11 +1,16 @@
 # apiVersion -- Version of the SeldonDeployment CRD
 apiVersion: machinelearning.seldon.io/v1
 
+protocol: seldon
+transport: rest
+
 model:
   # model.implementation -- Implementation of Prepackaged Model Server
   implementation: ""
   # model.uri -- Model's URI for prepackaged model server
   uri: ""
+  # model.envSecretRefName -- The model secret name for enviroment variables
+  envSecretRefName: ""
   # model.image -- Docker image used by the model
   image: ""
   # model.env -- Environment variables injected into the model's container
@@ -20,6 +25,8 @@ model:
     enabled: false
     # logger.url -- Remote URL for logger
     url: ""
+  mlflow:
+    xtype: ""
 
 # replicas -- Number of replicas for the predictor
 replicas: 1