Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit hook for black and fix linter #1020

Merged
merged 3 commits into from
Oct 31, 2019

Conversation

adriangonz
Copy link
Contributor

@adriangonz adriangonz commented Oct 31, 2019

Changelog

  • Fix linter by running black on a couple files which weren't following the styleguide.
  • Add pre-commit hook to .pre-commit-config.yaml.
  • Add note on black to CONTRIBUTING.md.

@adriangonz
Copy link
Contributor Author

/uncc @gsunner @ryandawsonuk
/cc @axsaucedo @jklaise @cliveseldon

@seldondev seldondev requested review from axsaucedo, ukclivecox and jklaise and removed request for gsunner and ryandawsonuk October 31, 2019 14:34
@adriangonz adriangonz changed the title Fix linter Add pre-commit hook for black and fix linter Oct 31, 2019
@adriangonz adriangonz mentioned this pull request Oct 31, 2019
@adriangonz
Copy link
Contributor Author

/ok-to-test
/test this

@axsaucedo
Copy link
Contributor

Nice one!

@axsaucedo
Copy link
Contributor

/approve
Lint passes now 🎉

@adriangonz
Copy link
Contributor Author

/pony

@seldondev
Copy link
Collaborator

@adriangonz: pony image

In response to this:

/pony

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@axsaucedo
Copy link
Contributor

/lgtm

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev seldondev merged commit 65829a8 into SeldonIO:master Oct 31, 2019
@axsaucedo axsaucedo removed their assignment May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants