Namespaced Operator #1142

ukclivecox · 2019-11-26T16:48:31Z

Allow namespaced Operator
Allow Operator that manages only resources with controler-id matching label

Includes:

Updated install docs
Example notebook showing clusterwide, namespaced and labelled operators all running together.

ukclivecox · 2019-11-26T17:25:30Z

Need to ensure webhook config is scoped: https://kubernetes.io/docs/reference/access-authn-authz/extensible-admission-controllers/#matching-requests-rules

phsiao · 2019-11-26T17:32:33Z

How to prevent the cluster-wide operator from competing with namespaced operator?

ukclivecox · 2019-11-26T17:35:59Z

How to prevent the cluster-wide operator from competing with namespaced operator?

Good question. Is that good practice to have a cluster wide and namespaced operators in same cluster?

…ler-id

seldondev · 2019-12-06T16:34:11Z

Fri Dec 6 16:34:10 UTC 2019
The logs for [pr-build] [14] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1142/14.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1142 --build=14

seldondev · 2019-12-06T16:34:17Z

Fri Dec 6 16:34:16 UTC 2019
The logs for [lint] [15] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1142/15.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1142 --build=15

phsiao

Did a quick review on the code and some of the configuration. I think the controller-id label key should have a prefix.

operator/controllers/seldondeployment_controller.go

seldondev · 2019-12-07T09:57:05Z

Sat Dec 7 09:57:04 UTC 2019
The logs for [pr-build] [18] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1142/18.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1142 --build=18

seldondev · 2019-12-07T09:57:09Z

Sat Dec 7 09:57:08 UTC 2019
The logs for [lint] [19] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1142/19.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1142 --build=19

seldondev · 2019-12-07T10:39:41Z

Sat Dec 7 10:39:39 UTC 2019
The logs for [pr-build] [20] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1142/20.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1142 --build=20

seldondev · 2019-12-07T10:39:46Z

Sat Dec 7 10:39:46 UTC 2019
The logs for [lint] [21] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1142/21.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1142 --build=21

seldondev · 2019-12-09T11:56:15Z

Mon Dec 9 11:56:14 UTC 2019
The logs for [pr-build] [22] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1142/22.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1142 --build=22

seldondev · 2019-12-09T11:56:19Z

Mon Dec 9 11:56:18 UTC 2019
The logs for [lint] [23] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1142/23.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1142 --build=23

notebooks/multiple_operators.ipynb

ryandawsonuk · 2019-12-09T11:36:20Z

operator/config/rbac/kustomization.yaml

- auth_proxy_service.yaml
- auth_proxy_role.yaml
- auth_proxy_role_binding.yaml
+#- auth_proxy_service.yaml


Is this bit intentional? Just double-checking

yes. Wanted to simplify the install by removing the proxy auth.

ryandawsonuk · 2019-12-09T13:12:32Z

/ok-to-test
/test integration

seldondev · 2019-12-09T13:13:45Z

Mon Dec 9 13:13:43 UTC 2019
The logs for [pr-build] [24] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1142/24.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1142 --build=24

seldondev · 2019-12-09T13:14:11Z

Mon Dec 9 13:14:10 UTC 2019
The logs for [integration] [25] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1142/25.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1142 --build=25

seldondev · 2019-12-09T13:14:12Z

Mon Dec 9 13:14:11 UTC 2019
The logs for [lint] [26] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1142/26.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1142 --build=26

ryandawsonuk · 2019-12-09T15:10:52Z

/lgtm
/approve

seldondev · 2019-12-09T15:11:02Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ryandawsonuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [ryandawsonuk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

seldondev · 2019-12-09T15:12:39Z

Mon Dec 9 15:12:38 UTC 2019
The logs for [pr-build] [27] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1142/27.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1142 --build=27

seldondev · 2019-12-09T15:12:48Z

Mon Dec 9 15:12:47 UTC 2019
The logs for [lint] [28] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1142/28.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1142 --build=28

seldondev · 2019-12-09T20:45:34Z

Mon Dec 9 20:45:33 UTC 2019
The logs for [pr-build] [29] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1142/29.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1142 --build=29

seldondev · 2019-12-09T20:45:44Z

Mon Dec 9 20:45:43 UTC 2019
The logs for [lint] [30] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1142/30.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1142 --build=30

Initial namespaced operator update - kustomize changes

86d573e

seldondev added do-not-merge/work-in-progress size/L labels Nov 26, 2019

Allow namespaced operators and initial work on operators with control…

a7b58d5

…ler-id

ukclivecox mentioned this pull request Nov 28, 2019

Dynamic Engine version support at Seldon operator #871

Closed

ukclivecox added 3 commits November 28, 2019 16:47

add controller id example and use of labels for controller

b8c5f6e

Update helm

7833b14

Updates for namespaced and controlerId operators and helm conversion

d7d0b38

seldondev added size/XL and removed size/L labels Dec 4, 2019

Update helm for namespaced operator

d193d0c

seldondev added size/XXL and removed size/XL labels Dec 5, 2019

ukclivecox added 2 commits December 6, 2019 11:47

Add example notebook on installing multiple operators onto 1 cluster

43c1de9

Add docs and notebook

bab53b2

ukclivecox changed the title ~~WIP: Namespaced Operator~~ Namespaced Operator Dec 6, 2019

seldondev removed the do-not-merge/work-in-progress label Dec 6, 2019

ukclivecox requested a review from ryandawsonuk December 6, 2019 16:03

ukclivecox added 2 commits December 6, 2019 16:28

rebase

aec0b28

fix formatting typo

a375281

phsiao suggested changes Dec 6, 2019

View reviewed changes

operator/controllers/seldondeployment_controller.go Outdated Show resolved Hide resolved

operator/controllers/seldondeployment_controller.go Show resolved Hide resolved

seldondev assigned phsiao Dec 6, 2019

ukclivecox added 2 commits December 7, 2019 09:51

Change controller-id to seldon.io/controller-id

d602c63

rebase

f436c74

Updated go.mod from rebase

1654acf

add missing model.yaml

9468910

ryandawsonuk reviewed Dec 9, 2019

View reviewed changes

seldondev added the ok-to-test label Dec 9, 2019

seldondev assigned ryandawsonuk Dec 9, 2019

seldondev added the lgtm label Dec 9, 2019

seldondev added the approved label Dec 9, 2019

axsaucedo merged commit acc8cf2 into SeldonIO:master Dec 9, 2019

ukclivecox deleted the 670_namespaced_operator branch February 14, 2020 11:37

snyk-bot mentioned this pull request Jul 30, 2020

[Snyk] Upgrade @tensorflow/tfjs from 0.12.7 to 0.15.3 #2216

Closed

axsaucedo unassigned phsiao and ryandawsonuk May 13, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Namespaced Operator #1142

Namespaced Operator #1142

ukclivecox commented Nov 26, 2019 •

edited

Loading

ukclivecox commented Nov 26, 2019

phsiao commented Nov 26, 2019

ukclivecox commented Nov 26, 2019

seldondev commented Dec 6, 2019

seldondev commented Dec 6, 2019

phsiao left a comment

seldondev commented Dec 7, 2019

seldondev commented Dec 7, 2019

seldondev commented Dec 7, 2019

seldondev commented Dec 7, 2019

seldondev commented Dec 9, 2019

seldondev commented Dec 9, 2019

ryandawsonuk Dec 9, 2019

ukclivecox Dec 9, 2019

ryandawsonuk commented Dec 9, 2019

seldondev commented Dec 9, 2019

seldondev commented Dec 9, 2019

seldondev commented Dec 9, 2019

ryandawsonuk commented Dec 9, 2019

seldondev commented Dec 9, 2019

seldondev commented Dec 9, 2019

seldondev commented Dec 9, 2019

seldondev commented Dec 9, 2019

seldondev commented Dec 9, 2019

Namespaced Operator #1142

Namespaced Operator #1142

Conversation

ukclivecox commented Nov 26, 2019 • edited Loading

ukclivecox commented Nov 26, 2019

phsiao commented Nov 26, 2019

ukclivecox commented Nov 26, 2019

seldondev commented Dec 6, 2019

seldondev commented Dec 6, 2019

phsiao left a comment

Choose a reason for hiding this comment

seldondev commented Dec 7, 2019

seldondev commented Dec 7, 2019

seldondev commented Dec 7, 2019

seldondev commented Dec 7, 2019

seldondev commented Dec 9, 2019

seldondev commented Dec 9, 2019

ryandawsonuk Dec 9, 2019

Choose a reason for hiding this comment

ukclivecox Dec 9, 2019

Choose a reason for hiding this comment

ryandawsonuk commented Dec 9, 2019

seldondev commented Dec 9, 2019

seldondev commented Dec 9, 2019

seldondev commented Dec 9, 2019

ryandawsonuk commented Dec 9, 2019

seldondev commented Dec 9, 2019

seldondev commented Dec 9, 2019

seldondev commented Dec 9, 2019

seldondev commented Dec 9, 2019

seldondev commented Dec 9, 2019

ukclivecox commented Nov 26, 2019 •

edited

Loading