Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated s2i Dockerfiles to build using requirements.txt #1160

Merged
merged 14 commits into from
Dec 2, 2019
Merged
3 changes: 2 additions & 1 deletion wrappers/s2i/python-conda/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ WORKDIR /microservice

COPY ./s2i/bin/ /s2i/bin

RUN pip install seldon-core
COPY requirements.txt ./requirements.txt
RUN pip install -r requirements.txt

EXPOSE 5000
1 change: 1 addition & 0 deletions wrappers/s2i/python-conda/requirements.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
seldon-core
adriangonz marked this conversation as resolved.
Show resolved Hide resolved
7 changes: 2 additions & 5 deletions wrappers/s2i/python/Dockerfile.gpu.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,8 @@ WORKDIR /microservice
COPY ./s2i/bin/ /s2i/bin

# keep install of seldon-core after the COPY to force re-build of layer
RUN pip3 install seldon-core
RUN pip3 install tensorflow-gpu==1.13.1

# Numpy version 1.16.1 required for tf-gpu
RUN pip3 install numpy==1.16.1
COPY requirements_gpu.txt ./requirements.txt
RUN pip3 install -r requirements.txt


EXPOSE 5000
3 changes: 2 additions & 1 deletion wrappers/s2i/python/Dockerfile.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ WORKDIR /microservice
COPY ./s2i/bin/ /s2i/bin

# keep install of seldon-core after the COPY to force re-build of layer
RUN pip install seldon-core
COPY requirements.txt ./requirements.txt
RUN pip install -r requirements.txt

EXPOSE 5000
1 change: 1 addition & 0 deletions wrappers/s2i/python/requirements.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
seldon-core
4 changes: 4 additions & 0 deletions wrappers/s2i/python/requirements_gpu.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
seldon-core
tensorflow-gpu==1.13.1
numpy==1.16.1