Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue 820 #1315

Merged
merged 4 commits into from
Jan 9, 2020
Merged

fix issue 820 #1315

merged 4 commits into from
Jan 9, 2020

Conversation

RafalSkolasinski
Copy link
Contributor

@RafalSkolasinski RafalSkolasinski commented Jan 6, 2020 •
edited
Loading

WIP fix for #820.

@seldondev seldondev requested review from axsaucedo and gsunner January 6, 2020 17:41
@seldondev
Copy link
Collaborator

Mon Jan 6 17:42:14 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1315/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1315 --build=1

@seldondev
Copy link
Collaborator

Mon Jan 6 17:42:19 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1315/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1315 --build=2

@RafalSkolasinski RafalSkolasinski mentioned this pull request Jan 6, 2020
Closed
@RafalSkolasinski
Copy link
Contributor Author

/retest

@seldondev
Copy link
Collaborator

Mon Jan 6 17:48:49 UTC 2020
The logs for [lint] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1315/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1315 --build=3

@seldondev
Copy link
Collaborator

Mon Jan 6 17:54:49 UTC 2020
The logs for [pr-build] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1315/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1315 --build=4

@seldondev
Copy link
Collaborator

Mon Jan 6 17:54:56 UTC 2020
The logs for [lint] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1315/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1315 --build=5

@axsaucedo
Copy link
Contributor

/test integration

@seldondev
Copy link
Collaborator

Mon Jan 6 20:08:18 UTC 2020
The logs for [integration] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1315/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1315 --build=6

axsaucedo
axsaucedo suggested changes Jan 6, 2020
View reviewed changes
Copy link
Contributor

@axsaucedo axsaucedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid, I added a couple of comments. Would be good to add this to all the tests (I can see it's been added to the ones for the prepackaged model servers)

testing/scripts/seldon_e2e_utils.py Outdated Show resolved Hide resolved
testing/scripts/seldon_e2e_utils.py Outdated Show resolved Hide resolved
testing/scripts/seldon_e2e_utils.py Outdated Show resolved Hide resolved
testing/scripts/seldon_e2e_utils.py Outdated Show resolved Hide resolved
testing/scripts/seldon_e2e_utils.py Outdated Show resolved Hide resolved
@axsaucedo
Copy link
Contributor

/test integration

@seldondev
Copy link
Collaborator

Mon Jan 6 22:38:12 UTC 2020
The logs for [integration] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1315/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1315 --build=7

@seldondev seldondev added size/L and removed size/M labels Jan 7, 2020
@seldondev
Copy link
Collaborator

Tue Jan 7 10:13:47 UTC 2020
The logs for [pr-build] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1315/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1315 --build=8

@seldondev
Copy link
Collaborator

Tue Jan 7 10:13:57 UTC 2020
The logs for [lint] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1315/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1315 --build=9

@RafalSkolasinski
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Tue Jan 7 12:27:39 UTC 2020
The logs for [pr-build] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1315/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1315 --build=10

@seldondev
Copy link
Collaborator

Tue Jan 7 12:27:46 UTC 2020
The logs for [lint] [11] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1315/11.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1315 --build=11

@seldondev
Copy link
Collaborator

Tue Jan 7 12:28:21 UTC 2020
The logs for [integration] [12] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1315/12.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1315 --build=12

@RafalSkolasinski
Copy link
Contributor Author

/retest

@seldondev
Copy link
Collaborator

Tue Jan 7 13:31:12 UTC 2020
The logs for [integration] [13] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1315/13.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1315 --build=13

@seldondev
Copy link
Collaborator

Tue Jan 7 14:07:51 UTC 2020
The logs for [pr-build] [14] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1315/14.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1315 --build=14

@seldondev
Copy link
Collaborator

Tue Jan 7 14:08:02 UTC 2020
The logs for [lint] [15] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1315/15.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1315 --build=15

@RafalSkolasinski
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Tue Jan 7 16:18:51 UTC 2020
The logs for [pr-build] [21] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1315/21.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1315 --build=21

@seldondev
Copy link
Collaborator

Tue Jan 7 16:19:02 UTC 2020
The logs for [lint] [22] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1315/22.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1315 --build=22

@seldondev
Copy link
Collaborator

Tue Jan 7 16:19:09 UTC 2020
The logs for [integration] [23] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1315/23.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1315 --build=23

@seldondev
Copy link
Collaborator

Tue Jan 7 16:22:06 UTC 2020
The logs for [pr-build] [24] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1315/24.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1315 --build=24

@seldondev
Copy link
Collaborator

Tue Jan 7 16:22:24 UTC 2020
The logs for [lint] [25] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1315/25.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1315 --build=25

@RafalSkolasinski
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Tue Jan 7 19:53:19 UTC 2020
The logs for [integration] [26] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1315/26.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1315 --build=26

@ryandawsonuk ryandawsonuk mentioned this pull request Jan 8, 2020
Closed
@RafalSkolasinski
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Wed Jan 8 15:36:31 UTC 2020
The logs for [integration] [27] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1315/27.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1315 --build=27

@RafalSkolasinski
Automatically find deployment names in e2e tests, closes #820
3b11655 
New approach is based on getting deyployment names directly from
SeldonDeployment objects. This allow to avoid hard-coded hashes in
test scripts.
@RafalSkolasinski
apply fix to other tests and iterate over deployments in wait_for_rol…
f9612fd 
…lout
@RafalSkolasinski
adjust to tests being run with Python 3.6
08c3ef1
@RafalSkolasinski
modify local operator tests to use proper namespace and run helm unin…
524cd39 
…stall at the end
@seldondev
Copy link
Collaborator

Wed Jan 8 16:14:23 UTC 2020
The logs for [pr-build] [28] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1315/28.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1315 --build=28

@seldondev
Copy link
Collaborator

Wed Jan 8 16:14:27 UTC 2020
The logs for [lint] [29] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1315/29.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1315 --build=29

@RafalSkolasinski
Copy link
Contributor Author

/test integration

@RafalSkolasinski RafalSkolasinski changed the title WIP: issue 820 fix issue 820 Jan 8, 2020
@seldondev
Copy link
Collaborator

Wed Jan 8 17:08:16 UTC 2020
The logs for [integration] [30] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1315/30.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1315 --build=30

@axsaucedo
Copy link
Contributor

Nice one
/approve
/lgtm

@seldondev seldondev added the lgtm label Jan 9, 2020
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Thu Jan 9 10:49:23 UTC 2020
The logs for [pr-build] [31] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1315/31.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1315 --build=31

@seldondev
Copy link
Collaborator

Thu Jan 9 10:49:31 UTC 2020
The logs for [lint] [32] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1315/32.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1315 --build=32

@seldondev
Copy link
Collaborator

Thu Jan 9 10:57:43 UTC 2020
The logs for [pr-build] [33] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1315/33.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1315 --build=33

@seldondev
Copy link
Collaborator

Thu Jan 9 10:57:58 UTC 2020
The logs for [lint] [34] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1315/34.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1315 --build=34

@seldondev seldondev merged commit 29f9de0 into SeldonIO:master Jan 9, 2020
@axsaucedo axsaucedo removed their assignment May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axsaucedo axsaucedo axsaucedo requested changes

@gsunner gsunner Awaiting requested review from gsunner

Assignees
No one assigned
Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RafalSkolasinski @seldondev @axsaucedo