Replace print with logging.info in python/tests. Closes #1372 #1424
Conversation
|
Tue Feb 11 13:38:46 UTC 2020 impatient try |
|
Tue Feb 11 13:38:49 UTC 2020 impatient try |
|
Tue Feb 11 13:57:09 UTC 2020 impatient try |
|
Tue Feb 11 13:57:09 UTC 2020 impatient try |
|
Tue Feb 11 14:12:39 UTC 2020 impatient try |
|
Tue Feb 11 14:12:42 UTC 2020 impatient try |
|
/test integration |
|
Wed Feb 12 07:55:42 UTC 2020 impatient try |
|
@RafalSkolasinski nice one! Looking at some of these files I think the issue probably wasn't as specific in scope as some would benefit more from being replaced with logging as having the output would still be valuable. Probably we should rename this issue from remove print statements to move fully to logging,as I think it's also useful to put all of the current ones under a logger.info or logger.debug |
|
I think having good logging is important for the main wrapper code as this
one will be executed always in normal operation.
So in principle if something is meant to help debug issues should be
independent of being defined on methods of user-defined model.
Let's discuss more later today!
…On Wed, 12 Feb 2020, 08:13 Alejandro Saucedo, ***@***.***> wrote:
@RafalSkolasinski <https://github.com/RafalSkolasinski> nice one! Looking
at some of these files I think the issue probably wasn't as specific in
scope as some would benefit more from being replaced with logging as having
the output would still be valuable. Probably we should rename this issue
from remove print statements to move fully to logging,as I think it's also
useful to put all of the current ones under a logger.info or logger.debug
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1424?email_source=notifications&email_token=AINAE2ZWCBZ5ZMJ6EDYD2PLRCOVUJA5CNFSM4KTA6QZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELP2ZNQ#issuecomment-585084086>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AINAE22GJBGJVBULV2HKCQ3RCOVUJANCNFSM4KTA6QZA>
.
|
|
Wed Feb 12 10:59:32 UTC 2020 impatient try |
|
Wed Feb 12 10:59:33 UTC 2020 impatient try |
RafalSkolasinski
changed the title
|
Wed Feb 12 11:01:40 UTC 2020 impatient try |
|
Wed Feb 12 11:01:43 UTC 2020 impatient try |
|
@axsaucedo replaced |
|
Wed Feb 12 11:08:26 UTC 2020 impatient try |
|
Wed Feb 12 11:08:47 UTC 2020 impatient try |
|
Wed Feb 12 11:11:22 UTC 2020 impatient try |
|
Wed Feb 12 11:11:28 UTC 2020 impatient try |
|
Just in case: |
|
Wed Feb 12 11:13:29 UTC 2020 impatient try |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cliveseldon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
As in title. Fixes #1372.