Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Make inclusion of metrics in SeldonMessage configurable in 1.1" #1624

Merged
merged 9 commits into from
Mar 27, 2020
Merged

Revert "Make inclusion of metrics in SeldonMessage configurable in 1.1" #1624

merged 9 commits into from
Mar 27, 2020

Conversation

RafalSkolasinski
Copy link
Contributor

Reverts #1590 because seldondev merged it before integration tests passed.

@RafalSkolasinski
Revert "make testing more robust: wait_for_rollout will repeat get_de…
ecba07a 
…ployment_names if that is empty"

This reverts commit fc10d48.
@RafalSkolasinski
Revert "partially revert 8afb6f3 to read env var only once"
efc4b94 
This reverts commit 5f5f520.
@RafalSkolasinski
Revert "add note in docs"
bd24d06 
This reverts commit aa72cbd.
@RafalSkolasinski
Revert "improve hadling and testing of INCLUDE_METRICS_IN_CLIENT_RESP…
1530dc2 
…ONSE env variable"

This reverts commit c330b23.
@RafalSkolasinski
Revert "fixes from code review"
6fe3dbe 
This reverts commit 03ba1b3.
@RafalSkolasinski
Revert "add tests for custom metrics returned to client"
09c84ef 
This reverts commit 258dd55.
@RafalSkolasinski
Revert "simplify metrics test code"
001aa67 
This reverts commit 6987fe2.
@RafalSkolasinski
Revert "skip metrics also in raw methods"
c8842b7 
This reverts commit be6969c.
@RafalSkolasinski
Revert "WIP: skip metrics in meta returned to client"
b597718 
This reverts commit 9d32de7.
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ryandawsonuk

If they are not already assigned, you can assign the PR to them by writing /assign @ryandawsonuk in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Fri Mar 27 16:38:00 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1624/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1624 --build=1

@seldondev
Copy link
Collaborator

Fri Mar 27 16:38:06 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1624/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1624 --build=2

@axsaucedo axsaucedo merged commit 1c2b511 into master Mar 27, 2020
@RafalSkolasinski RafalSkolasinski mentioned this pull request Mar 27, 2020
Merged
seldondev pushed a commit that referenced this pull request Mar 30, 2020
@RafalSkolasinski @seldondev
Revert "Revert "Make inclusion of metrics in SeldonMessage configurab…
6818fb3 
…le in 1.1" (#1624)"

This reverts commit 1c2b511 and effectively restores original PR.
@RafalSkolasinski RafalSkolasinski deleted the revert-1590-issue/1582 branch January 11, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RafalSkolasinski @seldondev @axsaucedo