Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: storage for prom #2407

Closed
wants to merge 2 commits into from

Conversation

ryandawsonuk
Copy link
Contributor

for #2401

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign ryandawsonuk
You can assign the PR to them by writing /assign @ryandawsonuk in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Thu Sep 10 12:31:20 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2407/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2407 --build=2

@seldondev
Copy link
Collaborator

Thu Sep 10 12:31:20 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2407/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2407 --build=1

@ryandawsonuk ryandawsonuk changed the title storage for prom WIP: storage for prom Sep 11, 2020
@ryandawsonuk
Copy link
Contributor Author

After discussion we don't want to do this here as pvc won't work OOTB for kind. Would go to pending unless kind is specifically configured for storage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants