-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Alibi-Detect wrapper and drift and outlier examples #2626
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Wed Nov 11 15:00:48 UTC 2020 impatient try |
Wed Nov 11 15:00:53 UTC 2020 impatient try |
Wed Nov 11 15:03:07 UTC 2020 impatient try |
Wed Nov 11 15:03:56 UTC 2020 impatient try |
@@ -37,9 +37,17 @@ | |||
}, | |||
{ | |||
"cell_type": "code", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I notice this notebook still says "Tested on GKE with Knative 0.13 and Istio 1.3.1". We should change that to 0.18 and 1.7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Fri Nov 13 08:33:58 UTC 2020 impatient try |
Fri Nov 13 08:34:05 UTC 2020 impatient try |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axsaucedo, ryandawsonuk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fri Nov 13 17:20:43 UTC 2020 impatient try |
Fri Nov 13 17:20:57 UTC 2020 impatient try |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #2551
Special notes for your reviewer:
Does this PR introduce a user-facing change?: