Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates for redhat scans #2870

Merged
merged 5 commits into from
Jan 29, 2021
Merged

updates for redhat scans #2870

merged 5 commits into from
Jan 29, 2021

Conversation

ryandawsonuk
Copy link
Contributor

@ryandawsonuk ryandawsonuk commented Jan 22, 2021 •
edited
Loading

fixes #2869

Been a change to RH scanning process. New yum update required to pass vulnerability scanning.

Also noticed one of the images was ubi7, which I think won't work next time we try it.

Putting these updates in place before our next release.

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign ryandawsonuk
You can assign the PR to them by writing /assign @ryandawsonuk in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Fri Jan 22 11:48:05 UTC 2021
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2870/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2870 --build=1

@seldondev
Copy link
Collaborator

Fri Jan 22 11:48:05 UTC 2021
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2870/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2870 --build=2

@axsaucedo
Copy link
Contributor

@ryandawsonuk the engine image is being depricated - will it still be required to keep up to date with all the vulnerability checks?

@seldondev seldondev added size/S and removed size/L labels Jan 22, 2021
@seldondev
Copy link
Collaborator

Fri Jan 22 17:34:18 UTC 2021
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2870/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2870 --build=3

@seldondev
Copy link
Collaborator

Fri Jan 22 17:34:20 UTC 2021
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2870/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2870 --build=4

@ryandawsonuk
Copy link
Contributor Author

Should not be necessary to keep scanning engine going forward. Only including it here in case we publish it with 1.6.0.

@seldondev
Copy link
Collaborator

Mon Jan 25 14:47:12 UTC 2021
The logs for [lint] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2870/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2870 --build=6

@seldondev
Copy link
Collaborator

Mon Jan 25 14:47:15 UTC 2021
The logs for [pr-build] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2870/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2870 --build=5

@seldondev
Copy link
Collaborator

Mon Jan 25 15:19:36 UTC 2021
The logs for [pr-build] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2870/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2870 --build=7

@seldondev
Copy link
Collaborator

Mon Jan 25 15:19:55 UTC 2021
The logs for [lint] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2870/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2870 --build=8

ryandawsonuk
ryandawsonuk commented Jan 26, 2021
View reviewed changes
components/seldon-request-logger/Dockerfile
@@ -1,7 +1,7 @@
FROM registry.access.redhat.com/ubi8/python-36
FROM registry.access.redhat.com/ubi8/python-38
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I published this for 1.5.1. Had to change this base image for it to pass.

@seldondev
Copy link
Collaborator

Tue Jan 26 14:47:57 UTC 2021
The logs for [pr-build] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2870/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2870 --build=9

@seldondev
Copy link
Collaborator

Tue Jan 26 14:47:59 UTC 2021
The logs for [lint] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2870/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2870 --build=10

@ryandawsonuk
Copy link
Contributor Author

/ok-to-test
/test integration

@seldondev
Copy link
Collaborator

Tue Jan 26 14:53:55 UTC 2021
The logs for [lint] [13] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2870/13.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2870 --build=13

@seldondev
Copy link
Collaborator

Tue Jan 26 14:53:54 UTC 2021
The logs for [pr-build] [11] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2870/11.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2870 --build=11

@seldondev
Copy link
Collaborator

Tue Jan 26 14:54:00 UTC 2021
The logs for [integration] [12] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2870/12.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2870 --build=12

@adriangonz
Copy link
Contributor

/test integration

@seldondev
Copy link
Collaborator

Wed Jan 27 14:50:38 UTC 2021
The logs for [integration] [14] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2870/14.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2870 --build=14

@RafalSkolasinski
Copy link
Contributor

/test integration

@seldondev
Copy link
Collaborator

Wed Jan 27 18:08:34 UTC 2021
The logs for [integration] [15] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2870/15.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2870 --build=15

@ryandawsonuk
Copy link
Contributor Author

Getting a different failure with each re-run.

Failed test in 15.log: TestTagsPythonS2iK8s.test_model_combiner_grpc
Failed test in 14.log: test-label-update-1-4-0
Failed test in 12.log: TestPrepack.test_text_alibi_explainer

@ryandawsonuk
Copy link
Contributor Author

/retest

@seldondev
Copy link
Collaborator

Thu Jan 28 09:53:32 UTC 2021
The logs for [integration] [16] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2870/16.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2870 --build=16

@ukclivecox
Copy link
Contributor

/test integration

@seldondev
Copy link
Collaborator

Thu Jan 28 10:10:14 UTC 2021
The logs for [integration] [17] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2870/17.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2870 --build=17

@axsaucedo
Copy link
Contributor

@ryandawsonuk looks good, good to go or still needs to run notebook tests?

@axsaucedo
Copy link
Contributor

Merging as discussed with @ryandawsonuk

@axsaucedo axsaucedo merged commit f5f8731 into SeldonIO:master Jan 29, 2021
@ryandawsonuk ryandawsonuk mentioned this pull request Feb 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ukclivecox ukclivecox Awaiting requested review from ukclivecox

Assignees
No one assigned
Labels
ok-to-test size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CVE checks update for redhat image scans
6 participants
@ryandawsonuk @seldondev @axsaucedo @adriangonz @RafalSkolasinski @ukclivecox