-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating spacy notebook #3076
Updating spacy notebook #3076
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one! I just added a few comments below.
examples/models/sklearn_spacy_text/sklearn_spacy_text_classifier_example.ipynb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs linter seems to be complaining about the header hierarchy:
/__w/seldon-core/seldon-core/doc/source/examples/sklearn_spacy_text_classifier_example.nblink:1805: WARNING: Title level inconsistent:
looking for now-outdated files... none found
a) Using CURL from the CLI
^^^^^^^^^^^^^^^^^^^^^^^^^^
/__w/seldon-core/seldon-core/doc/source/examples/sklearn_spacy_text_classifier_example.nblink:1928: WARNING: Title level inconsistent:
b) Using the Python SeldonClient
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axsaucedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Updating spacy example notebook
Which issue(s) this PR fixes:
Part of Issue #3072
Special notes for your reviewer:
Does this PR introduce a user-facing change?: