Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating spacy notebook #3076

Merged
merged 3 commits into from
Mar 19, 2021
Merged

Conversation

nadinet
Copy link
Contributor

@nadinet nadinet commented Mar 19, 2021

What this PR does / why we need it:
Updating spacy example notebook

Which issue(s) this PR fixes:

Part of Issue #3072

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

None

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@adriangonz adriangonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! I just added a few comments below.

examples/models/sklearn_spacy_text/Dockerfile Show resolved Hide resolved
examples/models/sklearn_spacy_text/reddit_clf.json Outdated Show resolved Hide resolved
Copy link
Contributor

@adriangonz adriangonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs linter seems to be complaining about the header hierarchy:

 /__w/seldon-core/seldon-core/doc/source/examples/sklearn_spacy_text_classifier_example.nblink:1805: WARNING: Title level inconsistent:
looking for now-outdated files... none found

a) Using CURL from the CLI
^^^^^^^^^^^^^^^^^^^^^^^^^^
/__w/seldon-core/seldon-core/doc/source/examples/sklearn_spacy_text_classifier_example.nblink:1928: WARNING: Title level inconsistent:

b) Using the Python SeldonClient
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

@seldondev seldondev added size/L and removed size/XL labels Mar 19, 2021
@axsaucedo
Copy link
Contributor

/approve

@axsaucedo axsaucedo requested a review from adriangonz March 19, 2021 16:06
@seldondev seldondev merged commit 1283499 into SeldonIO:master Mar 19, 2021
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants