Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation updates for the Ambassador Install process and to introduce CRD based config. #3163

Merged

Conversation

cakuros
Copy link
Contributor

@cakuros cakuros commented May 5, 2021

What this PR does / why we need it:
This PR is intended to update the Ambassador Ingress configuration to the more current Emissary and Ambassador Edge Stack installation suggestions. It primarily updates the API version to v2 and introduces Custom Resource Definition based configuration, as well as a basic example on how to translate CRD configs to Annotations, for those who want to use the seldon.io/ambassador-config annotation.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Changed primary image mirror from quay.io to docker.io.
Changed API version numbers in examples from v1 to v2.
Added more details on Ambassador feature capabilities.
Added some explanations to the custom configuration section to explain the difference between annotation-based config and CRD.
Removed old note regarding gRPC issues.
Added both Ambassador install options to the "Seldon Setup" notebook.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@seldondev
Copy link
Collaborator

Hi @cakuros. Thanks for your PR.

I'm waiting for a SeldonIO or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign cliveseldon
You can assign the PR to them by writing /assign @cliveseldon in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cakuros
Copy link
Contributor Author

cakuros commented May 6, 2021

/assign @cliveseldon

@ukclivecox ukclivecox merged commit 8249af5 into SeldonIO:master May 6, 2021
@ukclivecox
Copy link
Contributor

Thanks @cakuros

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants