-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tracing debug #3240
Fix tracing debug #3240
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
/test integration |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test integration |
/test notebooks |
/test integration |
/test notebooks |
/test integration |
1 similar comment
/test integration |
/test notebooks |
1 similar comment
/test notebooks |
/test integration |
/test notebooks |
All tests seem to pass and no extra review comments - merging 👍 |
@cliveseldon: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here. |
What this PR does / why we need it:
Ensures tracing is not activated if TRACING=0 in python wrapper.
Which issue(s) this PR fixes:
Fixes #3158
Special notes for your reviewer:
Does this PR introduce a user-facing change?: