Add Status Conditions to CR #3503
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
ukclivecox
changed the title
|
/test integration |
ukclivecox
changed the title
There was a problem hiding this comment.
Looks great - I did a first pass, I was thinkign it would be great to add documentation (including in upgrading.md), and perhaps a couple new integration tests that could check some of the specific status (like HPA and Keda - although the latter may be more fiddly so could be left for later)
| @@ -1072,6 +1072,18 @@ func (r *SeldonDeploymentReconciler) createIstioServices(components *components, | |||
| } | |||
| } | |||
|
|
|||
| if ready { | |||
| var reason string | |||
| if len(components.virtualServices) > 0 { | |||
There was a problem hiding this comment.
For this wouldn't we need to add the exact number of services, just in case for example if there's a new canary/shadow added and the virtualservice needs to be created for it
notebooks/protocol_examples.ipynb
Outdated
| @@ -96,7 +96,7 @@ | |||
| { | |||
| "data": { | |||
| "text/plain": [ | |||
| "'1.9.0-dev'" | |||
| "'1.10.0-dev'" | |||
There was a problem hiding this comment.
seems this is not pointing to 1.11.0-dev
|
/test integration |
|
/test notebooks |
|
/test integation |
|
/test notebooks |
1 similar comment
|
/test notebooks |
|
/test integration |
|
/test integration |
|
/test notebooks |
|
/test notebooks |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axsaucedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Upgrade to 0.20 k8s librarues and Go 1.16 * Add initial status conditions for sdeps * finish conditions * update licenses * add status conditions to test * update notebooks and dockerfiles * update convert script to increase time after a kubectl wait condition
What this PR does / why we need it:
You can do use
kubectllike:Which issue(s) this PR fixes:
Fixes #3265
Special notes for your reviewer:
Does this PR introduce a user-facing change?: