Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sherif akoush/sc 2549/alibi v1 fixes #3744

Merged
merged 31 commits into from
Nov 23, 2021
Merged

Sherif akoush/sc 2549/alibi v1 fixes #3744

merged 31 commits into from
Nov 23, 2021

Conversation

sakoush
Copy link
Member

@sakoush sakoush commented Nov 16, 2021 •
edited
Loading

What this PR does / why we need it:

  • update alibi-explain-server to use alibi load_explainer util
  • remove v2 protocol feature as it is now done via mlserver
  • wire up ALE explainer

Which issue(s) this PR fixes:

Fixes #3708

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

  • fix remaining tests
  • check change with SD
  • fix docs / example

@sakoush sakoush marked this pull request as draft November 16, 2021 18:28
@sakoush sakoush marked this pull request as ready for review November 18, 2021 17:45
@RafalSkolasinski
Copy link
Contributor

/retest

RafalSkolasinski
RafalSkolasinski approved these changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@RafalSkolasinski RafalSkolasinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, a lot of good improvements!

.github/workflows/alibiexplainer_tests.yml
- name: test-python
run: |
pip install --upgrade pip setuptools
make -C components/alibi-explain-server dev_install build_apis test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth to split install dependencies and actual test like above?

components/alibi-explain-server/tests/test_ale.py
explanation = ale.explain(X_test.tolist())
exp_json = json.loads(explanation.to_json())
print(exp_json)
ale = ALE(alibi_model)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The skmodel is now not passed to ALE. Maybe we can drop it from this test?

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RafalSkolasinski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [3744]: [Not Found]

13 similar comments
@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [3744]: [Not Found]

@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [3744]: [Not Found]

@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [3744]: [Not Found]

@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [3744]: [Not Found]

@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [3744]: [Not Found]

@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [3744]: [Not Found]

@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [3744]: [Not Found]

@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [3744]: [Not Found]

@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [3744]: [Not Found]

@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [3744]: [Not Found]

@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [3744]: [Not Found]

@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [3744]: [Not Found]

@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [3744]: [Not Found]

@RafalSkolasinski RafalSkolasinski merged commit 3feef65 into SeldonIO:master Nov 23, 2021
stephen37 pushed a commit to stephen37/seldon-core that referenced this pull request Dec 21, 2021
@sakoush
Sherif akoush/sc 2549/alibi v1 fixes (SeldonIO#3744)
09e817f 
* First cut to fix explainer v1

* add ale

* first test in

* remove v2 support

* revert change and fix Makefile (for Tabular)

* add fmt

* remove kfserving and add tornado and fastapi as first level deps

* fmt

* update poetry.lock

* remove setup.py as we use poetry now

* fix anchorimage

* optimise imports

* fix AnchorText

* fix makefile (up to anchorimage)

* fix kernelshap test

* fix kernel shap in Makefile

* fix integrated gradients

* treeshap fixed

* fix treeshap Makefile

* fix ALE

* disable trition, v2 protocol is now via mlserver alibi runtime

* add lint / v1 explainer to GA

* fix GA

* fix GA take 3

* try installing gsutil

* fmt

* add a test for app

* create anchor_tabular model

* create anchor tabular for income model

* remove unused import

* use graph name instead of sdep name (needed for tensorflow model explainer)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafalSkolasinski RafalSkolasinski RafalSkolasinski approved these changes

Assignees
No one assigned
Labels
approved size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix alibi-explain-server to use alibi load_explainer helper function
3 participants
@sakoush @RafalSkolasinski @seldondev