Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batch processor: always prioritize tags from model #3789

Merged
merged 1 commit into from
Dec 7, 2021
Merged

batch processor: always prioritize tags from model #3789

merged 1 commit into from
Dec 7, 2021

Conversation

RafalSkolasinski
Copy link
Contributor

Seldon models always prioritise in their response tags generated by the model itself.
This was not the case for batch processor with raw inputs and batch_size > 1 (not released, still on master).

This is to fix it.

Existing batch processor tests still passes:

est_batch_processor.py::TestBatchWorker::test_batch_worker PASSED                                                                    [ 33%]
test_batch_processor.py::TestBatchWorker::test_batch_worker_raw_predict_ndarray PASSED                                                [ 66%]
test_batch_processor.py::TestBatchWorker::test_batch_worker_raw_predict_tensor PASSED                                                 [100%]

@RafalSkolasinski
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

@RafalSkolasinski: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
integration 07d4bb1 link /test integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@axsaucedo
Copy link
Contributor

Seems failure is on rolling update tests which are flaky and code looks good, merging
/approve

@axsaucedo axsaucedo merged commit 9417602 into SeldonIO:master Dec 7, 2021
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

seldondev pushed a commit that referenced this pull request Dec 7, 2021
stephen37 pushed a commit to stephen37/seldon-core that referenced this pull request Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants