Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude caBundle field when cert-manager is enabled #3807

Merged

Conversation

juldou
Copy link
Contributor

@juldou juldou commented Dec 17, 2021

What this PR does / why we need it:
It fixes the issue mentioned below. caBundle field should be excluded when using cert-manager.

Which issue(s) this PR fixes:
Fixes #3806

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@seldondev
Copy link
Collaborator

Hi @juldou. Thanks for your PR.

I'm waiting for a SeldonIO or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@juldou
Copy link
Contributor Author

juldou commented Dec 17, 2021

/assign @majolo

Copy link
Contributor

@majolo majolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for contributing @juldou !

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: majolo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev seldondev merged commit 34efac6 into SeldonIO:master Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

seldon-core operator webhook chart generated caBundle field when cert-manager is enabled
3 participants