Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated license branch from master to main for hashicorp/go-version #3829

Merged
merged 4 commits into from
Jan 6, 2022

Conversation

axsaucedo
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #3828

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Copy link
Contributor

@agrski agrski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Looks like these are the only files affected:

$ rg 'hashicorp.*tar' -l
operator/Dockerfile.redhat
operator/Dockerfile
executor/Dockerfile.executor
executor/Dockerfile.executor.redhat

@axsaucedo
Copy link
Contributor Author

/test integration

@axsaucedo
Copy link
Contributor Author

Nice one - thanks @agrski , will run the build in CI and merge 👍

@axsaucedo
Copy link
Contributor Author

All images now building - merging
/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agrski, axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@axsaucedo axsaucedo merged commit 6546bea into master Jan 6, 2022
@seldondev
Copy link
Collaborator

@axsaucedo: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
integration d518e74 link /test integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@RafalSkolasinski RafalSkolasinski deleted the axsaucedo-patch-22 branch February 21, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change of branch for hashicorp/go-version breaks image build
3 participants